Skip to content

chore(cli-repl): account for changes to nightly driver typings #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addaleax merged 2 commits into from
Oct 17, 2025
Merged

chore(cli-repl): account for changes to nightly driver typings #2556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
204b2c7
chore(cli-repl): account for changes to nightly driver typings
addaleax Oct 15, 2025
2a4fca4
fixup: more explicit match
addaleax Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/cli-repl/src/crypt-library-paths.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
import path from 'path';
import { promises as fs, constants as fsConstants } from 'fs';
import type { MongoshBus } from '@mongosh/types';
import type { AutoEncryptionOptions } from 'mongodb';

export const SHARED_LIBRARY_SUFFIX =
type SharedObjectSuffix = 'so' | 'dylib' | 'dll';
export const SHARED_LIBRARY_SUFFIX: SharedObjectSuffix =
process.platform === 'win32'
? 'dll'
: process.platform === 'darwin'
? 'dylib'
: 'so';
export type CryptSharedLibPath = NonNullable<
NonNullable<AutoEncryptionOptions['extraOptions']>['cryptSharedLibPath']
>;

export interface CryptLibraryPathResult {
cryptSharedLibPath?: string;
cryptSharedLibPath?: CryptSharedLibPath;
expectedVersion?: { version: bigint; versionStr: string };
}

Expand Down Expand Up @@ -54,7 +59,10 @@ export async function getCryptLibraryPaths(
),
// Location of the shared library in the zip and tgz packages
path.resolve(bindir, `mongosh_crypt_v1.${SHARED_LIBRARY_SUFFIX}`),
]) {
// NB: The types here intentionally mismatch, as we rename the
// library file to avoid conflicts with system installations of
// the crypt_shared library.
] as CryptSharedLibPath[]) {
try {
const permissionsMismatch = await ensureMatchingPermissions(
libraryCandidate,
Expand Down