From 550eee31b0318247d201a0f67655f133905e1a05 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 9 Apr 2021 15:57:57 +0200 Subject: [PATCH] fix(cli-repl): print newline after password prompt Otherwise, you end up with `Enter password: ****************Current Mongosh Log ID: [...]`. --- packages/cli-repl/src/cli-repl.spec.ts | 1 + packages/cli-repl/src/cli-repl.ts | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/cli-repl/src/cli-repl.spec.ts b/packages/cli-repl/src/cli-repl.spec.ts index 774f02a48e..45f12c3294 100644 --- a/packages/cli-repl/src/cli-repl.spec.ts +++ b/packages/cli-repl/src/cli-repl.spec.ts @@ -484,6 +484,7 @@ describe('CliRepl', () => { } expect(threw).to.be.true; expect(auth.password).to.equal('i want food'); + expect(output).to.match(/^Enter password: \**$/m); input.write('.exit\n'); }); diff --git a/packages/cli-repl/src/cli-repl.ts b/packages/cli-repl/src/cli-repl.ts index c479fd3f5a..f4b39f2d85 100644 --- a/packages/cli-repl/src/cli-repl.ts +++ b/packages/cli-repl/src/cli-repl.ts @@ -367,7 +367,11 @@ class CliRepl { }); this.output.write('Enter password: '); try { - (driverOptions.auth as any).password = (await passwordPromise).toString(); + try { + (driverOptions.auth as any).password = (await passwordPromise).toString(); + } finally { + this.output.write('\n'); + } } catch (error) { await this._fatalError(error); }