From ba1c8bcad6716b78b32b510d01afe647188b907b Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 19 Apr 2021 18:44:46 +0200 Subject: [PATCH 1/2] chore(build): give each bundling test its own tmpdir This *might* fix flakiness like this: [2021/04/19 11:53:57.707] 1) compile generateBundle [2021/04/19 11:53:57.707] does not attempt to load ES6 modules because parcel cannot handle them properly: [2021/04/19 11:53:57.707] Error: ENOENT: no such file or directory, open 'Z:\data\mci\b2b62ed7d54f2bcd3c5e2ddd5846c7d9\src\packages\tmp\test-build-1618833168859-0.6650505642822344\a.js' --- packages/build/src/compile/generate-bundle.spec.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/build/src/compile/generate-bundle.spec.ts b/packages/build/src/compile/generate-bundle.spec.ts index 12f58f99ad..41044f6ee9 100644 --- a/packages/build/src/compile/generate-bundle.spec.ts +++ b/packages/build/src/compile/generate-bundle.spec.ts @@ -10,11 +10,12 @@ const execFile = promisify(childProcess.execFile); describe('compile generateBundle', function() { this.timeout(60_000); - const tmpdir = path.resolve( - __dirname, '..', '..', '..', 'tmp', `test-build-${Date.now()}-${Math.random()}` - ); + let tmpdir; beforeEach(async() => { + tmpdir = path.resolve( + __dirname, '..', '..', '..', 'tmp', `test-build-${Date.now()}-${Math.random()}` + ); await fs.mkdir(tmpdir, { recursive: true }); }); From 15841958863c4ffea6e815d0791de59cb2bfb1d2 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 20 Apr 2021 11:48:45 +0200 Subject: [PATCH 2/2] fixup! Co-authored-by: Michael Rose --- packages/build/src/compile/generate-bundle.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/build/src/compile/generate-bundle.spec.ts b/packages/build/src/compile/generate-bundle.spec.ts index 41044f6ee9..a92990debb 100644 --- a/packages/build/src/compile/generate-bundle.spec.ts +++ b/packages/build/src/compile/generate-bundle.spec.ts @@ -10,7 +10,7 @@ const execFile = promisify(childProcess.execFile); describe('compile generateBundle', function() { this.timeout(60_000); - let tmpdir; + let tmpdir: string; beforeEach(async() => { tmpdir = path.resolve(