From 9d2dc090c6f4ef426c53b803c187aaa07c1ed74f Mon Sep 17 00:00:00 2001 From: Michael Rose Date: Wed, 19 May 2021 19:34:50 +0200 Subject: [PATCH 1/2] fix(shell-api): ensure deprecation is handled in tests --- packages/shell-api/src/decorators.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shell-api/src/decorators.ts b/packages/shell-api/src/decorators.ts index df110b3d3e..9751de5c59 100644 --- a/packages/shell-api/src/decorators.ts +++ b/packages/shell-api/src/decorators.ts @@ -181,7 +181,7 @@ function wrapWithApiChecks any>(fn: T, className: s } function checkForDeprecation(internalState: ShellInternalState | undefined, className: string, fn: any) { - if (internalState && typeof fn === 'function' && fn.deprecated) { + if (internalState && typeof internalState.emitDeprecatedApiCall === 'function' && typeof fn === 'function' && fn.deprecated) { internalState.emitDeprecatedApiCall({ method: fn.name, class: className From 8ad668a3e34b3ef0d41917cd6533694de2b2ec46 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 20 May 2021 10:53:28 +0200 Subject: [PATCH 2/2] fixup --- packages/cli-repl/src/setup-logger-and-telemetry.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli-repl/src/setup-logger-and-telemetry.spec.ts b/packages/cli-repl/src/setup-logger-and-telemetry.spec.ts index 28f4a8ae83..4a1b67488d 100644 --- a/packages/cli-repl/src/setup-logger-and-telemetry.spec.ts +++ b/packages/cli-repl/src/setup-logger-and-telemetry.spec.ts @@ -243,7 +243,7 @@ describe('setupLoggerAndTelemetry', () => { it('buffers deprecated API calls', () => { setupLoggerAndTelemetry(logId, bus, () => logger, () => analytics); - expect(logOutput).to.be.empty; + expect(logOutput).to.have.lengthOf(1); expect(analyticsOutput).to.be.empty; const mongosh_version = require('../package.json').version;