chore: make sure we run test-and-build on non-PRs #1197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the GitHub Actions workflow condition that was preventing the test-and-build job from running on non-PR events (such as pushes to branches). The workflow was incorrectly checking pull request properties for all event types, which would fail for non-PR triggers.
Key Changes:
- Updated the workflow condition to explicitly allow non-PR events while maintaining Dependabot and fork filtering for PR events
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
approved these changes
Dec 8, 2025
gagik
added
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in the if-condition which caused the workflow to be skipped for all non-PR triggers