Skip to content

Conversation

@nirinchev
Copy link
Contributor

@nirinchev nirinchev commented Jan 24, 2025

Description

I was a bit annoyed that the dependabot workflows never run due to secrets missing. This adds a pull_request_target workflow which only runs for forks and dependabot PRs.

And since I was also annoyed by the constant warnings, I went ahead and added the return types for all functions.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@nirinchev nirinchev added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Jan 24, 2025
@nirinchev
Copy link
Contributor Author

I'm going to go ahead and merge this to test it out, but feel free to leave a review and I'll address any comments in a follow-up.

@nirinchev nirinchev merged commit 10814f0 into main Jan 24, 2025
8 checks passed
@nirinchev nirinchev deleted the ni/test-workflow-from-fork branch January 24, 2025 16:41
@nirinchev nirinchev mentioned this pull request Jan 24, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants