Use MongoClient and MongoReplicaSetClient #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eplicaSetConnection
|
Thanks, I hadn't had time to review MongoClient yet. We should update setup.py to require pymongo 2.4, and then clean out some of the support for older versions from init.py (like the switch around auto_start_request, and anything else I'm forgetting). |
|
Hey guys, you could maybe look at this ticket on gunicorn but related to flask-pymongo benoitc/gunicorn#450 |
|
I've done a bit of housekeeping, so I've updated setup.py, removed some unneeded PyMongo stuff and updated the tests to reflect this. Hopefully this also solves benoitc/gunicorn#450 although this may need to be tested further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PyMongo 2.4 MongoClient and MongoReplicaSetClient are meant to be used instead of Connection and ReplicaSetConnection. This commit changes it. There is one problem, this won't work with PyMongo versions less than 2.4...