Change stream fixes & log improvements. #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If an error happens in readOneChangeEvent, that error will now be reported via verifier.changeStreamErrChan. Previously the change stream would just stop. * The change stream will now stop after reporting an error. Previously it would keep iterating.
Previously this function’s verifier would on occasion fail because it would see the `drop` events from TearDownTest. This change causes that verifier’s change stream to end, which should prevent that failure.
These will hopefully aid in debugging.
tdq45gj
approved these changes
Nov 8, 2024
Collaborator
tdq45gj
left a comment
tdq45gj
left a comment
There was a problem hiding this comment.
I think those're going to be useful for debugging! LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEWER NOTE: I suggest reviewing individual commits. (I’m going to merge them as such rather than squashing.)
This applies a few small fixes to the change stream’s error handling and improves logging to facilitate easier diagnosis when tests fail.