Skip to content

Conversation

@FGasper
Copy link
Collaborator

@FGasper FGasper commented Nov 27, 2024

This changeset adds additional error codes to the retryer’s list of transient errors.

It also applies the retryer in several new places:

  • metadata prep at the beginning of check
  • generation of recheck tasks
  • clearing of the recheck queue
  • fetching failed & incomplete tasks
  • find the next worker task
  • get verification status
  • inserting a partition verification task
  • inserting a recheck task
  • updating a verification task
  • creating primary task
  • setting the primary task to complete

A few functions are renamed for clarity as well, and some function calls are rewritten to read (hopefully) a bit more clearly.

@FGasper FGasper requested a review from tdq45gj November 27, 2024 20:58
@FGasper FGasper marked this pull request as draft December 2, 2024 13:00
@FGasper FGasper force-pushed the REP-5329-retry-consistently branch from 59e21bd to 979fb74 Compare December 3, 2024 18:07
@FGasper FGasper marked this pull request as ready for review December 3, 2024 21:26
Copy link
Collaborator

@tdq45gj tdq45gj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FGasper FGasper merged commit 545a21e into mongodb-labs:main Dec 4, 2024
49 checks passed
@FGasper FGasper deleted the REP-5329-retry-consistently branch December 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants