Skip to content

RUBY-3665 - Fix Rubocop #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2025

Conversation

johnnyshields
Copy link
Contributor

@johnnyshields johnnyshields commented May 5, 2025

Fixes RUBY-3665

This PR fixes and upgrade Rubocop, which is not currently passing in this repo.

Specific changes:

  • Fix or skip cops so that Rubocop is green
  • Upgrade Rubocop and related Rubocop gems
  • Set min Ruby target version to 2.6 to match gemspec min Ruby version
  • Remove conditional logic for Ruby < 2.6
  • Add Rubocop step to Github Actions CI
  • Add test coverage for Ruby 3.4 coverage to Github Actions while we're here

Please also ensure Rubocop is running in Nevergreen.

@johnnyshields johnnyshields requested a review from a team as a code owner May 5, 2025 11:35
@johnnyshields johnnyshields requested review from jamis and removed request for a team May 5, 2025 11:35
- Set min Ruby target version to 2.6 to match gemspec min Ruby version
- Remove conditional logic for Ruby < 2.6
@alcaeus alcaeus requested review from comandeo-mongo and removed request for jamis May 5, 2025 15:14
@johnnyshields johnnyshields changed the title [RUBY-3665] Fix Rubocop RUBY-3665 - Fix Rubocop May 5, 2025
@comandeo-mongo
Copy link
Contributor

image

@comandeo-mongo comandeo-mongo merged commit 794dc7b into mongodb:master May 6, 2025
48 checks passed
@jamis jamis added the bug Fixes a bug, with no new features or broken compatibility label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes a bug, with no new features or broken compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants