RUBY-3675 Use append_cflags over modifying CFLAGS directly #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows installing bson gem on systems with GCC 15 - Fixes https://jira.mongodb.org/browse/RUBY-3675 References: - Ruby Lang - https://bugs.ruby-lang.org/issues/21290#61 - io-event gem - bug report: socketry/io-event#136 - bugfix patch (+6 / -6): socketry/io-event@d085761 - ed25519 gem - bug report: RubyCrypto/ed25519#44 - bugfix patch (+1 / -1): https://github.com/RubyCrypto/ed25519/pull/45/files#diff-805cf1ea9824de19b94dce429b3a3544fd9cb0b3cc278e571776c7d672cc1dfa - jaro_winkler gem - bug report: tonytonyjan/jaro_winkler#61 - bugfix patch (+1 / -1): https://github.com/tonytonyjan/jaro_winkler/pull/62/files#diff-594397402316a8262174f2dc8159b5a35560516bd3cd355b1bf657a6e0a973ce
|
Assigned |
|
@alexbevi Tested locally, and this is working. With this change |
pboling
added a commit
to omniauth/omniauth-identity
that referenced
this pull request
May 31, 2025
jamis
approved these changes
Jun 2, 2025
|
Thank you! 👍 |
jamis
changed the title
This was referenced Jun 13, 2025
stanhu
added a commit
to stanhu/cbor-ruby
that referenced
this pull request
Jul 23, 2025
This fixes a compilation issue in GCC 15 due `stdbool.h` not being included when `-std=c99` is in use. This occurs because the standard `configure` script shipped with Ruby does not properly test for `stdbool.h` on C23 compilers. It needs to pick up this change: https://cgit.git.savannah.gnu.org/cgit/autoconf.git/commit/?id=6dcecb780a69bd208088d666b299e92aa7ae7e80 The `append_cflags` approach is recommended over modifying CFLAGS since it ensures compatibility across different build environments by checking whether the flag is acceptable. Similar changes: * socketry/io-event#137 * mongodb/bson-ruby#355 Closes cabo#27
stanhu
added a commit
to stanhu/ruby-magic
that referenced
this pull request
Jul 27, 2025
This fixes a compilation issue in GCC 15 due `stdbool.h` not being included when `-std=c99` is in use. This occurs because the standard `configure` script shipped with older Ruby versions (prior to 3.4.5 and 3.3.9) do not properly test for `stdbool.h` on C23 compilers (https://bugs.ruby-lang.org/issues/21340). The `append_cflags` approach is recommended over modifying CFLAGS since it ensures compatibility across different build environments by checking whether the flag is acceptable. Similar changes: * socketry/io-event#137 * mongodb/bson-ruby#355 Closes kwilczynski#27
stanhu
added a commit
to stanhu/ruby-magic
that referenced
this pull request
Jul 27, 2025
This fixes a compilation issue in GCC 15 due `stdbool.h` not being included when `-std=c99` is in use. This occurs because the standard `configure` script shipped with older Ruby versions (prior to 3.4.5 and 3.3.9) do not properly test for `stdbool.h` on C23 compilers (https://bugs.ruby-lang.org/issues/21340). The `append_cflags` approach is recommended over modifying CFLAGS since it ensures compatibility across different build environments by checking whether the flag is acceptable. Similar changes: * socketry/io-event#137 * mongodb/bson-ruby#355
stanhu
added a commit
to stanhu/cbor-ruby
that referenced
this pull request
Jul 28, 2025
This fixes a compilation issue in GCC 15 due `stdbool.h` not being included when `-std=c99` is in use. This occurs because the standard `configure` script shipped with Ruby does not properly test for `stdbool.h` on C23 compilers. It needs to pick up this change: https://cgit.git.savannah.gnu.org/cgit/autoconf.git/commit/?id=6dcecb780a69bd208088d666b299e92aa7ae7e80 The `append_cflags` approach is recommended over modifying CFLAGS since it ensures compatibility across different build environments by checking whether the flag is acceptable. Similar changes: * socketry/io-event#137 * mongodb/bson-ruby#355 Closes cabo#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Please help me support open source by sponsoring me - @pboling