This repository was archived by the owner on May 1, 2025. It is now read-only.
DOCSP-33577 progress output clarification #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianf-mongodb
approved these changes
Nov 2, 2023
Contributor
ianf-mongodb
left a comment
ianf-mongodb
left a comment
There was a problem hiding this comment.
Hi @kennethdyer, this LGTM, I left a couple minor suggestions for consideration for naming / clarity.
kennethdyer
force-pushed
the
DOCSP-33577-progress-updates
branch
from
d1d95a0 to
10b8e6d
Compare
autarch
approved these changes
Jan 11, 2024
Collaborator
autarch
left a comment
autarch
left a comment
There was a problem hiding this comment.
LGTM. I had one small suggestion which you can take or leave.
kennethdyer
force-pushed
the
DOCSP-33577-progress-updates
branch
from
10b8e6d to
f324696
Compare
mdb-ashley
suggested changes
Jan 12, 2024
Collaborator
mdb-ashley
left a comment
mdb-ashley
left a comment
There was a problem hiding this comment.
A couple of quick fixes on this. Thanks for picking this one up!
Co-authored-by: Ashley Brown <98361885+mdb-ashley@users.noreply.github.com>
kennethdyer
added a commit
to kennethdyer/docs-cluster-to-cluster-sync
that referenced
this pull request
Jan 16, 2024
* DOCSP-33577 progress output clarification * Fixes per Ian * Fixes per Dave Rolsky * Fixes per Ashley Co-authored-by: Ashley Brown <98361885+mdb-ashley@users.noreply.github.com> --------- Co-authored-by: Ashley Brown <98361885+mdb-ashley@users.noreply.github.com>
mdb-ashley
added a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds notes on
progressoutput to note where field is global or per-mongosync.Staging
Output
Jira
DOCSP-33577
Build