Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

@ltran-mdb2
Copy link
Collaborator

DESCRIPTION

clarifying that the same version of mongosync must be used between all instances

STAGING

https://docs-mongodbcom-staging.corp.mongodb.com/cluster-sync/docsworker-xlarge/DOCSP-24715/multiple-mongosyncs/#configure-multiple-mongosync-instances

JIRA

https://jira.mongodb.org/browse/DOCSP-24715

BUILD LOG

https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=65831e407a5cb5fef5098dc8

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @ltran-mdb2! Just have a small question on the ordering of these sentences.

The number of ``mongosync`` instances must match the number of shards on
the source cluster. For a replica set source, you can only use one
``mongosync`` instance.
``mongosync`` instance. You must use the same version of ``mongosync``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question]

Would it make more sense to put this sentence after "The number of mongosync instances must match the number of shards on the source cluster." ?

This seems to be where we're talking about using multiple mongosync instances, so it might make sense to have this info there rather than where we're talking about only using one mongosync instance.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, just made the switch!

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jason-price-mongodb jason-price-mongodb merged commit 8f0f58b into mongodb:master Jan 5, 2024
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Jan 5, 2024
* DOCSP-24715 mongosyncs must be the same version

* DOCSP-24715 mongosyncs must be the same version

* DOCSP-24715 mongosyncs must be the same version

* empty

* DOCSP-24715 copy edit
jason-price-mongodb pushed a commit that referenced this pull request Jan 5, 2024
* DOCSP-24715 mongosyncs must be the same version

* DOCSP-24715 mongosyncs must be the same version

* DOCSP-24715 mongosyncs must be the same version

* empty

* DOCSP-24715 copy edit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants