-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP 24715 mongosyncs must be the same version #231
Conversation
jeff-allen-mongo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update @ltran-mdb2! Just have a small question on the ordering of these sentences.
source/multiple-mongosyncs.txt
Outdated
| The number of ``mongosync`` instances must match the number of shards on | ||
| the source cluster. For a replica set source, you can only use one | ||
| ``mongosync`` instance. | ||
| ``mongosync`` instance. You must use the same version of ``mongosync`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Question]
Would it make more sense to put this sentence after "The number of mongosync instances must match the number of shards on the source cluster." ?
This seems to be where we're talking about using multiple mongosync instances, so it might make sense to have this info there rather than where we're talking about only using one mongosync instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, just made the switch!
jeff-allen-mongo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ajayvijayakumar123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* DOCSP-24715 mongosyncs must be the same version * DOCSP-24715 mongosyncs must be the same version * DOCSP-24715 mongosyncs must be the same version * empty * DOCSP-24715 copy edit
DESCRIPTION
clarifying that the same version of mongosync must be used between all instances
STAGING
https://docs-mongodbcom-staging.corp.mongodb.com/cluster-sync/docsworker-xlarge/DOCSP-24715/multiple-mongosyncs/#configure-multiple-mongosync-instances
JIRA
https://jira.mongodb.org/browse/DOCSP-24715
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=65831e407a5cb5fef5098dc8
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?