This repository was archived by the owner on May 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-16529 Clarifies source/destination clusters on Quickstart #235
Merged
jason-price-mongodb
merged 4 commits into
mongodb:master
from
kennethdyer:DOCSP-16529-src-dest-type
Feb 8, 2024
Merged
DOCSP-16529 Clarifies source/destination clusters on Quickstart #235
jason-price-mongodb
merged 4 commits into
mongodb:master
from
kennethdyer:DOCSP-16529-src-dest-type
Feb 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdb-ashley
suggested changes
Jan 10, 2024
Collaborator
mdb-ashley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, Kenneth! I left a couple comments for your consideration.
68926d8 to
2931bc5
Compare
c3cb6ee to
3948611
Compare
mdb-ashley
approved these changes
Jan 17, 2024
Collaborator
mdb-ashley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Thanks, Kenneth!
3948611 to
55777e6
Compare
ajayvijayakumar123
suggested changes
Feb 8, 2024
Collaborator
ajayvijayakumar123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions / questions!
ajayvijayakumar123
approved these changes
Feb 8, 2024
Collaborator
ajayvijayakumar123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kennethdyer
added a commit
to kennethdyer/docs-cluster-to-cluster-sync
that referenced
this pull request
Feb 8, 2024
…odb#235) * DOCSP-16529 Clarifies source/destination clusters on Quickstart * Fixes per Ashley * Fixes per Ashley * Fixes per Ajay
jason-price-mongodb
pushed a commit
that referenced
this pull request
Feb 8, 2024
#259) * DOCSP-16529 Clarifies source/destination clusters on Quickstart * Fixes per Ashley * Fixes per Ashley * Fixes per Ajay
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarifies source and destination clusters on the Quickstart page.
Staging
Setup
Jira
DOCS-16529
Build