This repository was archived by the owner on May 1, 2025. It is now read-only.
DOCSP-34408 Updates Role Requirements #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ianf-mongodb
left a comment
ianf-mongodb
left a comment
There was a problem hiding this comment.
Thanks @kennethdyer I have left a few comments for consideration, cheers.
kennethdyer
force-pushed
the
DOCSP-34408-req-roles
branch
from
97aabfa to
c614368
Compare
Collaborator
Author
|
@ianf-mongodb, Changes applied with some additional refactor of the table. Anything else you'd like to see? |
Co-authored-by: ianf-mongodb <85948430+ianf-mongodb@users.noreply.github.com>
kennethdyer
force-pushed
the
DOCSP-34408-req-roles
branch
from
ae7320d to
743f518
Compare
kennethdyer
added a commit
to kennethdyer/docs-cluster-to-cluster-sync
that referenced
this pull request
Feb 2, 2024
* DOCSP-34408 Adds required role fore reversible sync * Fixes widths * Fixes columns * Test hlist * Test reformat * Test reformat * Test reformat * Test reformat * Test reformat * Reworks reversing to use note directive * Alphabetized roles lists * Tries different column layout * Reworks table * Reworks table * Reworks table * Fixes per Ian Co-authored-by: ianf-mongodb <85948430+ianf-mongodb@users.noreply.github.com> --------- Co-authored-by: ianf-mongodb <85948430+ianf-mongodb@users.noreply.github.com>
jmd-mongo
pushed a commit
that referenced
this pull request
Feb 2, 2024
* DOCSP-34408 Updates Role Requirements (#249) * DOCSP-34408 Adds required role fore reversible sync * Fixes widths * Fixes columns * Test hlist * Test reformat * Test reformat * Test reformat * Test reformat * Test reformat * Reworks reversing to use note directive * Alphabetized roles lists * Tries different column layout * Reworks table * Reworks table * Reworks table * Fixes per Ian Co-authored-by: ianf-mongodb <85948430+ianf-mongodb@users.noreply.github.com> --------- Co-authored-by: ianf-mongodb <85948430+ianf-mongodb@users.noreply.github.com> * Fixes build issue --------- Co-authored-by: ianf-mongodb <85948430+ianf-mongodb@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworks the table of roles required for self-managed clusters to include
dbAdminon destination cluster for reversing sync. Also updates the listed roles to render as links.Staging
Table
Jira
Build