This repository was archived by the owner on May 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-23343 Improve Atlas Connection String Example #272
Merged
jeff-allen-mongo
merged 8 commits into
mongodb:master
from
ajhuh-mdb:DOCSP-23343-connect-self-managed-cluster-atlas
Mar 1, 2024
Merged
DOCSP-23343 Improve Atlas Connection String Example #272
jeff-allen-mongo
merged 8 commits into
mongodb:master
from
ajhuh-mdb:DOCSP-23343-connect-self-managed-cluster-atlas
Mar 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-olson-mongodb
approved these changes
Feb 27, 2024
Collaborator
sarah-olson-mongodb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates @ajhuh-mdb! LGTM
mattt416
reviewed
Feb 27, 2024
mattt416
reviewed
Feb 27, 2024
mattt416
reviewed
Feb 27, 2024
mattt416
suggested changes
Feb 27, 2024
mattt416
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested a few minor changes. Thanks @ajhuh-mdb !
On a side note, would we want to make similar changes to the Connect Two Atlas Clusters section?
3aa71af to
9d4f673
Compare
9d4f673 to
f213590
Compare
b6b8815 to
796a7ec
Compare
Collaborator
Author
|
Thanks for taking a look @mattt416 ! This should be ready for another round of review. |
mattt416
approved these changes
Mar 1, 2024
mattt416
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @ajhuh-mdb !
ajhuh-mdb
added a commit
to ajhuh-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Mar 1, 2024
* DOCSP-23343 Improve Atlas Connection String Example * text edits * move note * MT feedback * test * tiny changes * * * fix staging
jeff-allen-mongo
pushed a commit
that referenced
this pull request
Mar 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
cluster1hosts and ports to better resemble an Atlas clusterSTAGING
JIRA
https://jira.mongodb.org/browse/DOCSP-23343
BUILD
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=65de2a577111165982ce24e8