-
Notifications
You must be signed in to change notification settings - Fork 39
DOCS-15748 Fix Mongosync Atlas doc examples #276
Conversation
339cc87 to
cebcff3
Compare
kennethdyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work @kanchana-mongodb, I left a few comments for your consideration.
| The generic connection string format for the Atlas cluster is: | ||
|
|
||
| .. code-block:: shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this code block, set the format to text since it's a raw example and doesn't need syntax highlighting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing these set to shell. They should be text or none.
| Use the connection information you gathered for the self-managed cluster | ||
| to create the connection strings for ``cluster0``: | ||
|
|
||
| .. code-block:: shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block doesn't provide a shell example of the --cluster0 option. Instead it's showing an example of the YAML configuration file, so it should use the yaml syntax highlighter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing the change here, either.
9ee194e to
f5e0542
Compare
AleGonez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes seems to be OK. However, I’m seeing some repeated information in Connect a Self-Managed Cluster to Atlas stage link. Following information is twice:
Can you please remove the duplicated info?
I'm not seeing this was part of the changes for this PR though but it would be good to correct it before publishing. Let me know if this will be handled in a separate PR and I can approve this one.
Actually, the connection string format is different - the first description shows the format for self-managed clusters followed by format for Atlas clusters. Clarified this in the page. Thanks! |
kennethdyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kanchana-mongodb, Didn't see the syntax highlighting changes but those are non-blocking suggestions. LGTM!
15d7848 to
e030cb2
Compare


Tested and updated doc for Atlas connection string fix. This required fixes in multiple pages.