Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

@kennethdyer
Copy link
Collaborator

@kennethdyer kennethdyer commented Mar 5, 2024

Description

Adds REVERSING to table of mongosync states.

Staging

JIRA

DOCS-16652

Build

@kennethdyer kennethdyer changed the title Docs 16652 mongosync states DOCS-16652 Adds Reversing State Mar 5, 2024
Copy link
Collaborator

@nvillahermosa-mdb nvillahermosa-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kenneth! I have some wording questions as far as clarity.

@kennethdyer
Copy link
Collaborator Author

kennethdyer commented Mar 5, 2024

@nvillahermosa-mdb , Changes applied. Anything else you'd like to see?

Copy link
Collaborator

@nvillahermosa-mdb nvillahermosa-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kenneth, LGTM

Copy link

@huan-Mongo huan-Mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-03-08 at 9 35 39 AM

Hi @kennethdyer Somehow the states table on the stage page disappears. Could you take a look? Thx.

@kennethdyer
Copy link
Collaborator Author

@huan-Mongo, I'm not sure what's happening on your end. When I'm running it in Chrome on Mac it renders correctly. I have noticed that tables sometimes take a beat to load, but I think that's a platform issue.

Copy link

@huan-Mongo huan-Mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I am able to see the rendering now, strange.

Anyway, I found an existing error on the COMMITTED state entry and there is a mistake in my ticket description as well.

@kennethdyer kennethdyer force-pushed the DOCS-16652-mongosync-states branch from d8d50b7 to bb1ddf6 Compare March 12, 2024 20:21
@kennethdyer
Copy link
Collaborator Author

@huan-Mongo, Changes applied. Anything else you'd like to see?

@huan-Mongo
Copy link

@kennethdyer I saw the - GET /progress is not aligned. Do you see the same?

Screenshot 2024-03-12 at 4 28 10 PM

@kennethdyer
Copy link
Collaborator Author

@huan-Mongo, Good catch. Fixed now.

Copy link

@huan-Mongo huan-Mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the change.

@jason-price-mongodb jason-price-mongodb merged commit 0afd344 into mongodb:master Mar 13, 2024
kennethdyer added a commit to kennethdyer/docs-cluster-to-cluster-sync that referenced this pull request Jul 22, 2024
* DOCS-16652 New mongosync states

* Fixes per Tim

* Fixes spacing

* Fixes per Nick

Co-authored-by: Nick Villahermosa <nick.villahermosa@mongodb.com>

* Fixes per Huan

* Fixes per Huan

---------

Co-authored-by: Nick Villahermosa <nick.villahermosa@mongodb.com>
sarah-olson-mongodb pushed a commit that referenced this pull request Jul 22, 2024
* DOCS-16652 New mongosync states

* Fixes per Tim

* Fixes spacing

* Fixes per Nick



* Fixes per Huan

* Fixes per Huan

---------

Co-authored-by: Nick Villahermosa <nick.villahermosa@mongodb.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants