-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-43721-migration-verifier-disclaimer #445
DOCSP-43721-migration-verifier-disclaimer #445
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jmd-mongo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this helpful addition, @amalhotra-mdb! I've left a question for your consideration and noted a small typo I think we can address.
Thanks!
Joe
source/reference/verification.txt
Outdated
| For installation instructions and usage limitations, see | ||
| `GitHub <https://github.com/mongodb-labs/migration-verifier>`__. | ||
|
|
||
| Unlike other verification methods, Migration Verifier can run concurrent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[typo]
I know this isn't part of the original ask, but could we fix this typo here? This should be "...can run concurrently...".
source/reference/verification.txt
Outdated
| confirm the sync was successful. | ||
|
|
||
| Migration Verifier does not support DDL operations. When using the Migration | ||
| Verifier, ensure that your source cluster does not use DDL commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question]
Is there a way to get more specific about what using DDL commands means in this context?
Are we saying users shouldn't run DDL operations on the source cluster during migration? Are there additional considerations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at this and for raising this questions, @jmd-mongo ! I tried to reword this sentence now to clarify that no DDL commands can be running on the source cluster when the user is verifying their data using Migration Verifier – lmk if you have any changes or suggestions!
I don't believe there are any additional considerations – the Limitations section in the Migration Verifier GitHub ReadMe I think gives the user all the specifics they'd need for this consideration.
Thanks so much for your help on this!
jmd-mongo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update. This one LGTM at this point.
Thanks!
Joe
tdq45gj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* DOCSP-43721-migration-verifier-disclaimer * make updates for migration verifier page * reword to clarify what using DDL commands means
DESCRIPTION
Migration Verifier has the following limitation, according to the Migration Verifier GitHub:
On the page instructing users on how to Verify using Migration Verifier and the Verify Data Transfer page, there is no disclaimer that Migration Verifier cannot handle DDL commands. This PR adds this disclaimer to both pages and updates the already existing link to the Migration Verifier GitHub to note the Limitation explanations in the GitHub readme.
STAGING
https://deploy-preview-445--docs-cluster-to-cluster-sync.netlify.app/reference/verification/#migration-verifier
https://deploy-preview-445--docs-cluster-to-cluster-sync.netlify.app/reference/verification/verifier/#verify-with-migration-verifier
JIRA
https://jira.mongodb.org/browse/DOCSP-43721
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?