Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

@amalhotra-mdb
Copy link
Collaborator

@amalhotra-mdb amalhotra-mdb commented Oct 22, 2024

DESCRIPTION

Migration Verifier has the following limitation, according to the Migration Verifier GitHub:

The verifier's iterative process can handle data changes while it is running, until you hit the writesOff endpoint. However, it cannot handle DDL commands. If the verifier receives a DDL change stream event (drop, dropDatabase, rename), the verification will fail. If an untracked DDL event (create, createIndexes, dropIndexes, modify) occurs, the verifier may miss the change.

On the page instructing users on how to Verify using Migration Verifier and the Verify Data Transfer page, there is no disclaimer that Migration Verifier cannot handle DDL commands. This PR adds this disclaimer to both pages and updates the already existing link to the Migration Verifier GitHub to note the Limitation explanations in the GitHub readme.

STAGING

JIRA

https://jira.mongodb.org/browse/DOCSP-43721

SELF-REVIEW CHECKLIST

  • Does each file have 3-5 taxonomy facet tags?
    See the taxonomy tagging instructions and this example PR
  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

EXTERNAL REVIEW REQUIREMENTS

What's expected of an external reviewer?

@netlify
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 6ac5881
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67180d4c35e15600087903fa
😎 Deploy Preview https://deploy-preview-445--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this helpful addition, @amalhotra-mdb! I've left a question for your consideration and noted a small typo I think we can address.

Thanks!
Joe

For installation instructions and usage limitations, see
`GitHub <https://github.com/mongodb-labs/migration-verifier>`__.

Unlike other verification methods, Migration Verifier can run concurrent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[typo]

I know this isn't part of the original ask, but could we fix this typo here? This should be "...can run concurrently...".

confirm the sync was successful.

Migration Verifier does not support DDL operations. When using the Migration
Verifier, ensure that your source cluster does not use DDL commands.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question]

Is there a way to get more specific about what using DDL commands means in this context?

Are we saying users shouldn't run DDL operations on the source cluster during migration? Are there additional considerations?

Copy link
Collaborator Author

@amalhotra-mdb amalhotra-mdb Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this and for raising this questions, @jmd-mongo ! I tried to reword this sentence now to clarify that no DDL commands can be running on the source cluster when the user is verifying their data using Migration Verifier – lmk if you have any changes or suggestions!

I don't believe there are any additional considerations – the Limitations section in the Migration Verifier GitHub ReadMe I think gives the user all the specifics they'd need for this consideration.

Thanks so much for your help on this!

Copy link
Collaborator

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update. This one LGTM at this point.

Thanks!
Joe

Copy link

@tdq45gj tdq45gj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdb-ashley mdb-ashley merged commit 15d1689 into mongodb:master Oct 23, 2024
3 checks passed
amalhotra-mdb added a commit to amalhotra-mdb/docs-cluster-to-cluster-sync that referenced this pull request Oct 23, 2024
* DOCSP-43721-migration-verifier-disclaimer

* make updates for migration verifier page

* reword to clarify what using DDL commands means
mdb-ashley pushed a commit that referenced this pull request Oct 23, 2024
* DOCSP-43721-migration-verifier-disclaimer

* make updates for migration verifier page

* reword to clarify what using DDL commands means
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants