This repository was archived by the owner on May 1, 2025. It is now read-only.
DOCSP-44549-specify-supporting-index-behavior #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jmd-mongo
reviewed
Oct 23, 2024
Collaborator
jmd-mongo
left a comment
jmd-mongo
left a comment
There was a problem hiding this comment.
Thanks for this update, @amalhotra-mdb! I've left a suggestion for your consideration.
Thanks,
Joe
source/reference/api/start.txt
Outdated
| - Optional. Sets whether sync creates a supporting index | ||
| for the shard key, if none exists. Defaults to ``false``. | ||
|
|
||
| For more information and current limitations, see |
Collaborator
There was a problem hiding this comment.
[suggestion]
I think we can remove "current" here and retain the same meaning.
Collaborator
Author
There was a problem hiding this comment.
Thank you for taking a look at this, @jmd-mongo ! BTY!
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Oct 24, 2024
* DOCSP-44549-specify-supporting-index-behavior * remove 'current'
sarah-olson-mongodb
pushed a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
mongosyncdocs do mention that unique indexes on the source cluster that are part of sharded collections on the destination cluster must have the shard key as a prefixmongosync, which can take a while to get to!This PR adds a link to the "Supporting Indexes" section in the
createSupportingIndexesdescription under the "Sharding Parameters" table to ensure users don't miss this key detail.STAGING
https://deploy-preview-448--docs-cluster-to-cluster-sync.netlify.app/reference/api/start/#sharding-parameters
JIRA
https://jira.mongodb.org/browse/DOCSP-44549
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?