Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

@ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Nov 1, 2024

DESCRIPTION

Adds rolling build limitation to mongosync behavior page under continuous sync considerations

STAGING

https://deploy-preview-462--docs-cluster-to-cluster-sync.netlify.app/reference/mongosync/mongosync-behavior/#rolling-index-builds
https://deploy-preview-462--docs-cluster-to-cluster-sync.netlify.app/reference/limitations/#rolling-index-builds

JIRA

https://jira.mongodb.org/browse/DOCSP-45041

SELF-REVIEW CHECKLIST

  • Does each file have 3-5 taxonomy facet tags?
    See the taxonomy tagging instructions and this example PR
  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

EXTERNAL REVIEW REQUIREMENTS

What's expected of an external reviewer?

@netlify
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit ba67817
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/672909022c8e780008f0a8c5
😎 Deploy Preview https://deploy-preview-462--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update, @ltran-mdb2! Overall, this looks good. I left a question for your consideration.

Thanks,
Joe

indexes:

- Build the index on the source before migration.
- Build the index on the source during migration with a non-rolling
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question]

Is there anywhere to link out for "non-rolling index build"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to link to the page on default index builds!

@ltran-mdb2
Copy link
Collaborator Author

Thanks for your feedback @jmd-mongo ! Could you take another look when you get a chance?

@ltran-mdb2 ltran-mdb2 requested a review from jmd-mongo November 4, 2024 17:53
Copy link
Collaborator

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @ltran-mdb2! This one LGTM.

Thanks,
Joe

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ltran-mdb2 ltran-mdb2 merged commit 6111830 into mongodb:master Nov 5, 2024
4 checks passed
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Nov 5, 2024
* DOCSP-45041-adding-rolling-limitation-to-behavior

* DOCSP-45041-adding-rolling-limitation-to-behavior

* DOCSP-45041 default index link
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Nov 5, 2024
* DOCSP-45041-adding-rolling-limitation-to-behavior

* DOCSP-45041-adding-rolling-limitation-to-behavior

* DOCSP-45041 default index link
ltran-mdb2 added a commit that referenced this pull request Nov 5, 2024
* DOCSP-45041-adding-rolling-limitation-to-behavior

* DOCSP-45041-adding-rolling-limitation-to-behavior

* DOCSP-45041 default index link
ltran-mdb2 added a commit that referenced this pull request Nov 5, 2024
* DOCSP-45041-adding-rolling-limitation-to-behavior

* DOCSP-45041-adding-rolling-limitation-to-behavior

* DOCSP-45041 default index link
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants