-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-44528-cutover-failure-warnings #485
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jmd-mongo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this issue, @ltran-mdb2! This is a great start. I left a question and noted a typo.
Thanks!
Joe
source/reference/cutover-process.txt
Outdated
| If you do not properly cutover from your source to your | ||
| destination, you may face the following issues: | ||
|
|
||
| - Garbage data on the destination cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question]
Can we find a different term to use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed to "unstructured and unneeded data" but also sent a slack message to Maria (ticket creator) for more clarity about what she meant by "garbage data"
source/reference/cutover-process.txt
Outdated
| - Garbage data on the destination cluster | ||
| - Commit failures with no option to rollback the sync | ||
| - Unrecoverable and undiagnosable ``mongosync`` errors | ||
| - Reduced application availibility, especially if there is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[typo]
This ought to be "availability" on line 37.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
jmd-mongo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates, @ltran-mdb2! This one LGTM at this point.
Thanks,
Joe
mvankeulen94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! a few changes from my end
source/reference/cutover-process.txt
Outdated
| If you do not properly cutover from your source to your | ||
| destination, you may face the following issues: | ||
|
|
||
| - Unstructured or unneeded data on the destination cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can rephrase to "inaccurate data"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
source/reference/cutover-process.txt
Outdated
| destination, you may face the following issues: | ||
|
|
||
| - Unstructured or unneeded data on the destination cluster | ||
| - Commit failures with no option to rollback the sync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can delete the "commit failures with no option [...]" bullet in favor of the unrecoverable and undiagnosable errors bullet below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
source/reference/cutover-process.txt
Outdated
| - Reduced application availability, especially if there is | ||
| application-side enforcement of document schema or other | ||
| characteristics | ||
| - Missing transactions on the destination cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing -> incomplete
source/reference/cutover-process.txt
Outdated
| After you submit a ``commit`` request, call the ``progress`` endpoint | ||
| to ensure that the ``mongosync`` state is ``COMMITTING`` or | ||
| ``COMMITTED``. | ||
| If the source cluster shuts down before mongosync can commit, such |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this a repeatable snippet so we don't have the same text copied over in 2 places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
source/reference/cutover-process.txt
Outdated
| - Missing transactions on the destination cluster | ||
| - Other unexpected cluster behavior | ||
|
|
||
| You must use the following steps to safely finalize your cutover process and achieve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest rephrasing "You must use the following steps" to "The following steps describe how to safely finalize your cutover process [...]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
edobranov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* DOCSP-44528-cutover-failure-warnings' * DOCSP-44528-cutover-failure-warnings' * DOCSP-44528 adding disaster warning * DOCSP-44528 adding disaster warning * DOCSP-44528 copy edit * DOCSP-44528 Maria comments (cherry picked from commit 6d0064c)
* DOCSP-44528-cutover-failure-warnings' * DOCSP-44528-cutover-failure-warnings' * DOCSP-44528 adding disaster warning * DOCSP-44528 adding disaster warning * DOCSP-44528 copy edit * DOCSP-44528 Maria comments (cherry picked from commit 6d0064c)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* DOCSP-44528-cutover-failure-warnings' * DOCSP-44528-cutover-failure-warnings' * DOCSP-44528 adding disaster warning * DOCSP-44528 adding disaster warning * DOCSP-44528 copy edit * DOCSP-44528 Maria comments (cherry picked from commit 6d0064c)
* DOCSP-44528-cutover-failure-warnings' * DOCSP-44528-cutover-failure-warnings' * DOCSP-44528 adding disaster warning * DOCSP-44528 adding disaster warning * DOCSP-44528 copy edit * DOCSP-44528 Maria comments (cherry picked from commit 6d0064c)
This reverts commit 6d0064c.
DESCRIPTION
Adding cutover warnings
STAGING
https://deploy-preview-485--docs-cluster-to-cluster-sync.netlify.app/reference/cutover-process/
https://deploy-preview-485--docs-cluster-to-cluster-sync.netlify.app/reference/mongosync/mongosync-behavior/#considerations-for-continuous-sync
JIRA
https://jira.mongodb.org/browse/DOCSP-44528
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?