This repository was archived by the owner on May 1, 2025. It is now read-only.
(DOCSP-45308) [c2c] add note on how to verify shard keys #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdb-ashley
approved these changes
Dec 13, 2024
Collaborator
mdb-ashley
left a comment
mdb-ashley
left a comment
There was a problem hiding this comment.
LGTM, just left a couple comments for your consideration. Thanks, Elyse!
| Shard Key Comparison | ||
| - To verify the transfer of shard keys to a synced collection, run a query on the ``config.collections`` | ||
| collection to find a document whose ``_id`` value is the namespace of the target collection. | ||
| Compare the ``key`` value of this document in the source and destination clusters. |
Collaborator
There was a problem hiding this comment.
[question] Should key be monospaced here?
Collaborator
Author
There was a problem hiding this comment.
I am using "key" to refer to the field name in the document, so if _id is monospaced, it feels more consistent to also monospace key. Do you think it would be helpful to emphasize thatkey is a field name? eg
"Compare the
keyfield value..."
Co-authored-by: Ashley Brown <98361885+mdb-ashley@users.noreply.github.com>
FGasper
suggested changes
Dec 14, 2024
Co-authored-by: Felipe Gasper <FGasper@users.noreply.github.com>
elyse-mdb
added a commit
to elyse-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Dec 16, 2024
* (DOCSP-45308) Edits. * (DOCSP-45308) Verify shard key. * (DOCSP-45308) Edits. * (DOCSP-45308) Condense code example. * (DOCSP-45308) edits. * (DOCSP-45308) Edits. * Update source/reference/verification.txt Co-authored-by: Ashley Brown <98361885+mdb-ashley@users.noreply.github.com> * Update source/reference/verification.txt Co-authored-by: Felipe Gasper <FGasper@users.noreply.github.com> --------- Co-authored-by: Ashley Brown <98361885+mdb-ashley@users.noreply.github.com> Co-authored-by: Felipe Gasper <FGasper@users.noreply.github.com>
This was referenced Dec 16, 2024
mdb-ashley
added a commit
that referenced
this pull request
Dec 17, 2024
* (DOCSP-45308) Edits. * (DOCSP-45308) Verify shard key. * (DOCSP-45308) Edits. * (DOCSP-45308) Condense code example. * (DOCSP-45308) edits. * (DOCSP-45308) Edits. * Update source/reference/verification.txt * Update source/reference/verification.txt --------- Co-authored-by: Ashley Brown <98361885+mdb-ashley@users.noreply.github.com> Co-authored-by: Felipe Gasper <FGasper@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
currently, we don't document how to verify that shard keys are migrated during a sync. that said, it is important that users do this, so it'd be great to add this note.
From Felipe Gasper:
STAGING
https://deploy-preview-526--docs-cluster-to-cluster-sync.netlify.app/reference/verification/
JIRA
DOCSP-45308
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?