From fa2b320b65bb315a09ba11b486eab0c29e435b48 Mon Sep 17 00:00:00 2001 From: Alison Huh Date: Tue, 21 Jan 2025 16:04:45 -0500 Subject: [PATCH 1/8] DOCSP-45863-embedded-verifier-migrations --- source/reference/verification/embedded.txt | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/source/reference/verification/embedded.txt b/source/reference/verification/embedded.txt index fdeb1e20e..61a987ebe 100644 --- a/source/reference/verification/embedded.txt +++ b/source/reference/verification/embedded.txt @@ -22,10 +22,6 @@ Verify with Embedded Verifier of checks on the destination cluster to verify the sync of supported collections. -.. important:: - - .. include:: /includes/fact-verifier-unsupported - .. versionadded:: 1.9 About this Task @@ -93,6 +89,16 @@ Steps Behavior -------- +Limitations +~~~~~~~~~~~ + +.. include:: /includes/fact-verifier-unsupported + +.. note:: + + Starting in version 1.10, the verifier checks metadata and indexes + for DDL events only when migrating from a pre-6.0 source cluster. + Verification Checks ~~~~~~~~~~~~~~~~~~~ From f7e994b3275df238145bbddec000cc11bf8d8be8 Mon Sep 17 00:00:00 2001 From: Alison Huh Date: Tue, 21 Jan 2025 16:23:35 -0500 Subject: [PATCH 2/8] * --- source/includes/fact-verifier-limitations.rst | 10 ++++++++++ source/reference/verification/embedded.txt | 10 ---------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/source/includes/fact-verifier-limitations.rst b/source/includes/fact-verifier-limitations.rst index 7b5bf6bf2..193b1fe1b 100644 --- a/source/includes/fact-verifier-limitations.rst +++ b/source/includes/fact-verifier-limitations.rst @@ -32,11 +32,21 @@ The embedded verifier has the following limitations: - .. include:: /includes/fact-verifier-buildIndexes +.. note:: + + Starting in version 1.10, the verifier checks metadata and indexes + for DDL events only when migrating from a pre-6.0 source cluster. + Unsupported Verification Checks ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .. include:: /includes/fact-verifier-unsupported +.. note:: + + Starting in version 1.10, the verifier checks metadata and indexes + for DDL events only when migrating from a pre-6.0 source cluster. + Unsupported Beta Features ~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/source/reference/verification/embedded.txt b/source/reference/verification/embedded.txt index 61a987ebe..5d399083a 100644 --- a/source/reference/verification/embedded.txt +++ b/source/reference/verification/embedded.txt @@ -89,16 +89,6 @@ Steps Behavior -------- -Limitations -~~~~~~~~~~~ - -.. include:: /includes/fact-verifier-unsupported - -.. note:: - - Starting in version 1.10, the verifier checks metadata and indexes - for DDL events only when migrating from a pre-6.0 source cluster. - Verification Checks ~~~~~~~~~~~~~~~~~~~ From 5f1a91a135b92c77dffb78d55ebf3072da58453c Mon Sep 17 00:00:00 2001 From: Alison Huh Date: Tue, 21 Jan 2025 16:36:31 -0500 Subject: [PATCH 3/8] * --- source/includes/fact-verifier-limitations.rst | 5 ----- 1 file changed, 5 deletions(-) diff --git a/source/includes/fact-verifier-limitations.rst b/source/includes/fact-verifier-limitations.rst index 193b1fe1b..e42294ae8 100644 --- a/source/includes/fact-verifier-limitations.rst +++ b/source/includes/fact-verifier-limitations.rst @@ -32,11 +32,6 @@ The embedded verifier has the following limitations: - .. include:: /includes/fact-verifier-buildIndexes -.. note:: - - Starting in version 1.10, the verifier checks metadata and indexes - for DDL events only when migrating from a pre-6.0 source cluster. - Unsupported Verification Checks ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ From dbda7e59c05aea97bce11d8c6fa4b45b0587691c Mon Sep 17 00:00:00 2001 From: Alison Huh Date: Thu, 23 Jan 2025 15:44:24 -0500 Subject: [PATCH 4/8] AV feedback --- source/includes/fact-verifier-limitations.rst | 8 ++++++-- source/reference/verification/embedded.txt | 11 +++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/source/includes/fact-verifier-limitations.rst b/source/includes/fact-verifier-limitations.rst index e42294ae8..2d6857326 100644 --- a/source/includes/fact-verifier-limitations.rst +++ b/source/includes/fact-verifier-limitations.rst @@ -39,8 +39,12 @@ Unsupported Verification Checks .. note:: - Starting in version 1.10, the verifier checks metadata and indexes - for DDL events only when migrating from a pre-6.0 source cluster. + Starting in version 1.10, the verifier checks for data inconsistencies from + a :ref:`DDL event ` that occurred on the + pre-6.0 source cluster during migration. + + To learn more about pre-6.0 migrations and DDL events, see + :ref:`Pre-6.0 Migration Limitations `. Unsupported Beta Features ~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/source/reference/verification/embedded.txt b/source/reference/verification/embedded.txt index 5d399083a..253cfcf3b 100644 --- a/source/reference/verification/embedded.txt +++ b/source/reference/verification/embedded.txt @@ -22,6 +22,17 @@ Verify with Embedded Verifier of checks on the destination cluster to verify the sync of supported collections. +.. note:: + + ``mongosync`` preserves document field order from the source cluster's + primary node because it reads using :readmode:`primary` read preference. The + embedded verifier checks documents in the destination cluster based on the + source cluster’s primary node, so it cannot verify discrepancies between + the different source cluster nodes. If an :term:`election` occurs, + discrepancies in document field order between the source cluster’s nodes will + cause the embedded verifier to fail the migration, even if ``mongosync`` + copied the documents correctly. + .. versionadded:: 1.9 About this Task From da372b59bebb180871283ef661e6c68cc998409c Mon Sep 17 00:00:00 2001 From: Alison Huh Date: Thu, 23 Jan 2025 15:49:50 -0500 Subject: [PATCH 5/8] wording --- source/reference/verification/embedded.txt | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/source/reference/verification/embedded.txt b/source/reference/verification/embedded.txt index 253cfcf3b..e127eb472 100644 --- a/source/reference/verification/embedded.txt +++ b/source/reference/verification/embedded.txt @@ -24,14 +24,14 @@ supported collections. .. note:: - ``mongosync`` preserves document field order from the source cluster's - primary node because it reads using :readmode:`primary` read preference. The - embedded verifier checks documents in the destination cluster based on the - source cluster’s primary node, so it cannot verify discrepancies between - the different source cluster nodes. If an :term:`election` occurs, - discrepancies in document field order between the source cluster’s nodes will - cause the embedded verifier to fail the migration, even if ``mongosync`` - copied the documents correctly. + ``mongosync`` reads using :readmode:`primary` read preference, so it + preserves document field order from the source cluster's primary node. The + embedded verifier also checks documents based on the source cluster’s primary + node. Because of this read preference, the verifier cannot verify + discrepancies between the different source cluster nodes. If an + :term:`election` occurs, discrepancies in document field order between the + source cluster’s nodes will cause the embedded verifier to fail the + migration, even if ``mongosync`` copied the documents correctly. .. versionadded:: 1.9 From 9013466913e5a57fe2a3d611bb7fce7218d11d49 Mon Sep 17 00:00:00 2001 From: Alison Huh Date: Fri, 24 Jan 2025 11:02:59 -0500 Subject: [PATCH 6/8] add ddl limitation --- source/includes/fact-verifier-limitations.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/source/includes/fact-verifier-limitations.rst b/source/includes/fact-verifier-limitations.rst index 2d6857326..0bd40393a 100644 --- a/source/includes/fact-verifier-limitations.rst +++ b/source/includes/fact-verifier-limitations.rst @@ -41,10 +41,11 @@ Unsupported Verification Checks Starting in version 1.10, the verifier checks for data inconsistencies from a :ref:`DDL event ` that occurred on the - pre-6.0 source cluster during migration. + pre-6.0 source cluster during migration. This is because pre-6.0 migrations + do not support DDL events. - To learn more about pre-6.0 migrations and DDL events, see - :ref:`Pre-6.0 Migration Limitations `. + To learn more, see :ref:`Pre-6.0 Migration Limitations + `. Unsupported Beta Features ~~~~~~~~~~~~~~~~~~~~~~~~~ From a4f10f1ce5e1875aa93141981456b55e72c52c4e Mon Sep 17 00:00:00 2001 From: Alison Huh Date: Fri, 24 Jan 2025 16:24:14 -0500 Subject: [PATCH 7/8] * --- source/reference/verification/embedded.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source/reference/verification/embedded.txt b/source/reference/verification/embedded.txt index e127eb472..db80c0f56 100644 --- a/source/reference/verification/embedded.txt +++ b/source/reference/verification/embedded.txt @@ -28,10 +28,10 @@ supported collections. preserves document field order from the source cluster's primary node. The embedded verifier also checks documents based on the source cluster’s primary node. Because of this read preference, the verifier cannot verify - discrepancies between the different source cluster nodes. If an - :term:`election` occurs, discrepancies in document field order between the - source cluster’s nodes will cause the embedded verifier to fail the - migration, even if ``mongosync`` copied the documents correctly. + discrepancies between the different source cluster nodes. In rare cases, + discrepancies in document field order between the source cluster’s nodes will + cause the embedded verifier to fail the migration, even if ``mongosync`` + copied the documents correctly. .. versionadded:: 1.9 From cce1439aff7d43089f81742eb9861ee2c8ff88ad Mon Sep 17 00:00:00 2001 From: Alison Huh Date: Tue, 28 Jan 2025 10:38:08 -0500 Subject: [PATCH 8/8] RS feedback --- source/reference/verification/embedded.txt | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/source/reference/verification/embedded.txt b/source/reference/verification/embedded.txt index db80c0f56..bd87fc62a 100644 --- a/source/reference/verification/embedded.txt +++ b/source/reference/verification/embedded.txt @@ -27,11 +27,10 @@ supported collections. ``mongosync`` reads using :readmode:`primary` read preference, so it preserves document field order from the source cluster's primary node. The embedded verifier also checks documents based on the source cluster’s primary - node. Because of this read preference, the verifier cannot verify - discrepancies between the different source cluster nodes. In rare cases, - discrepancies in document field order between the source cluster’s nodes will - cause the embedded verifier to fail the migration, even if ``mongosync`` - copied the documents correctly. + node, but at a different time from when ``mongosync`` reads them. Because of + this, in rare cases, discrepancies in document field order between the source + cluster’s nodes can cause the embedded verifier to fail the migration, even + if ``mongosync`` copied the documents correctly. .. versionadded:: 1.9