From 61d75c5a6605d455faddee9058f078faa85c2cad Mon Sep 17 00:00:00 2001 From: Chris Cho Date: Wed, 24 Jan 2024 13:29:14 -0500 Subject: [PATCH 1/4] 012424: add missing list items and update REVIEWING.md --- REVIEWING.md | 8 ++++---- source/includes/fundamentals-sections.rst | 6 ++++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/REVIEWING.md b/REVIEWING.md index 27e6616b..2bff6b89 100644 --- a/REVIEWING.md +++ b/REVIEWING.md @@ -1,4 +1,4 @@ -# Pull Request Reviewing Guidelines for Rust Driver Documentation +# Pull Request Reviewing Guidelines for the Rust Driver Documentation Contributions to the set of documents in this repository can receive reviews from one or both of the following types of reviews: @@ -22,9 +22,8 @@ Review the structure, wording, and flow of the information in the PR, and correc ### What Not to Review Nothing is completely off-limits to a copy review of a PR -- if you notice a technical issue, it's best to call it out early. -Copy reviewers should constrain their reviews to content within the -scope of the JIRA ticket, or otherwise create tickets to address -anything unrelated. +Copy reviewers should constrain their reviews to content within the scope of the JIRA ticket, or otherwise create PRs to address anything unrelated. + ## Technical Review @@ -42,3 +41,4 @@ While we welcome any recommendations on wording and structure, avoid blocking ap - Wording of sentences, although corrections to technical claims are welcome - Structure of the page - Any unchanged lines outside the PR unless relevant to the ticket acceptance criteria. + diff --git a/source/includes/fundamentals-sections.rst b/source/includes/fundamentals-sections.rst index 038da7dc..6f373a1c 100644 --- a/source/includes/fundamentals-sections.rst +++ b/source/includes/fundamentals-sections.rst @@ -19,9 +19,11 @@ Fundamentals section: - :ref:`Optimize Driver Performance ` - :ref:`Configure Asynchronous and Synchronous Runtimes ` - :ref:`Monitor Driver Events ` +- :ref:`Query and Write Geospatial Data ` +- :ref:`Store and Retrieve Large Files by Using GridFS ` .. - :atlas:`Connect to MongoDB Atlas from AWS Lambda ` - - :ref:`Store and Retrieve Large Files by Using GridFS ` + - :ref:`Encrypt Fields ` - - :ref:`Query and Write Geospatial Data ` + From f5c3179737b1841da95bd4f8540af1792f5b6397 Mon Sep 17 00:00:00 2001 From: Chris Cho Date: Wed, 24 Jan 2024 13:34:27 -0500 Subject: [PATCH 2/4] fix geo link --- source/includes/fundamentals-sections.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/includes/fundamentals-sections.rst b/source/includes/fundamentals-sections.rst index 6f373a1c..a8bc721f 100644 --- a/source/includes/fundamentals-sections.rst +++ b/source/includes/fundamentals-sections.rst @@ -19,7 +19,7 @@ Fundamentals section: - :ref:`Optimize Driver Performance ` - :ref:`Configure Asynchronous and Synchronous Runtimes ` - :ref:`Monitor Driver Events ` -- :ref:`Query and Write Geospatial Data ` +- :ref:`Query and Write Geospatial Data ` - :ref:`Store and Retrieve Large Files by Using GridFS ` .. From 62f9b8c1b30e7fd460b920e48537bb9e3facdfc2 Mon Sep 17 00:00:00 2001 From: Chris Cho Date: Wed, 24 Jan 2024 14:35:27 -0500 Subject: [PATCH 3/4] PRR fixes --- source/includes/fundamentals-sections.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/includes/fundamentals-sections.rst b/source/includes/fundamentals-sections.rst index a8bc721f..53b7d9be 100644 --- a/source/includes/fundamentals-sections.rst +++ b/source/includes/fundamentals-sections.rst @@ -15,8 +15,8 @@ Fundamentals section: - :ref:`Create a Time Series Collection ` - :ref:`Record Driver Events ` - :ref:`Run A Database Command ` -- :ref:`Specify Collations to Order Results ` - :ref:`Optimize Driver Performance ` +- :ref:`Specify Collations to Order Results ` - :ref:`Configure Asynchronous and Synchronous Runtimes ` - :ref:`Monitor Driver Events ` - :ref:`Query and Write Geospatial Data ` From 3216977260adc4b0f011658e793b17744969c77f Mon Sep 17 00:00:00 2001 From: Chris Cho Date: Wed, 24 Jan 2024 14:53:56 -0500 Subject: [PATCH 4/4] 012424: fix fundamentals section include order --- source/includes/fundamentals-sections.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/includes/fundamentals-sections.rst b/source/includes/fundamentals-sections.rst index 53b7d9be..00868440 100644 --- a/source/includes/fundamentals-sections.rst +++ b/source/includes/fundamentals-sections.rst @@ -16,9 +16,9 @@ Fundamentals section: - :ref:`Record Driver Events ` - :ref:`Run A Database Command ` - :ref:`Optimize Driver Performance ` -- :ref:`Specify Collations to Order Results ` - :ref:`Configure Asynchronous and Synchronous Runtimes ` - :ref:`Monitor Driver Events ` +- :ref:`Specify Collations to Order Results ` - :ref:`Query and Write Geospatial Data ` - :ref:`Store and Retrieve Large Files by Using GridFS `