This repository was archived by the owner on Aug 6, 2025. It is now read-only.
Dop 1986: Instantly see changes on docs on /deploy #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madelinezec
commented
May 11, 2021
madelinezec
commented
May 11, 2021
madelinezec
commented
May 11, 2021
madelinezec
commented
May 11, 2021
madelinezec
commented
May 11, 2021
madelinezec
commented
May 11, 2021
madelinezec
commented
May 11, 2021
casthewiz
reviewed
May 11, 2021
worker/package.json
Outdated
| "react": "^16.7.0", | ||
| "react-dom": "^16.7.0", | ||
| "remote-file-size": "^3.0.5", | ||
| "request": "^2.88.2", |
Contributor
There was a problem hiding this comment.
I'd be very hesitant to add request since it is deprecated and may not play well with native Promises (I think you'd have to add https://github.com/request/request-promise-native to get it to play well by default)
axios might be a viable alternative, it's fairly well used in a lot of JS apps and has pretty sane error handling patterns.
https://www.npmjs.com/package/axios#handling-errors
Contributor
Author
There was a problem hiding this comment.
Interesting! We currently use it in githubJob.js and this function is not used, by utils.js does call it here as well.
I'll give axios a try here
Contributor
There was a problem hiding this comment.
😕 oh boy
I bet something in the package.lock has request as a dependency and that's how it's available for import even though it wasn't specified in package.json until this pr
so basically if that's the case, the calls in those files work as a side effect of one our dependencies requiring it...
madelinezec
changed the title
GuruPKK
approved these changes
May 24, 2021
GuruPKK
added a commit
that referenced
this pull request
Jun 8, 2021
* Dop 1986: Instantly see changes on docs on /deploy (#422) * testing * testing * testing * save changes * test * commit before switch branch * commit before switch * temp * test * test * test * 5-11-21 Release version bump (#417) * clean up * clean * clean up * clean * clean * clean * lint * refactor * refactor * refactor * clean * add axios Co-authored-by: Cassidy Schaufele <cassidyschaufele@gmail.com> Co-authored-by: Kumaraguru Periyasamy Kanthasamy <48932104+GuruPKK@users.noreply.github.com> * pointing to right meta file * Update githubJob.js * Update Dockerfile * Update Dockerfile Co-authored-by: madelinezec <mez2113@columbia.edu> Co-authored-by: Cassidy Schaufele <cassidyschaufele@gmail.com>
GuruPKK
added a commit
that referenced
this pull request
Jun 8, 2021
* Dop 1986: Instantly see changes on docs on /deploy (#422) * testing * testing * testing * save changes * test * commit before switch branch * commit before switch * temp * test * test * test * 5-11-21 Release version bump (#417) * clean up * clean * clean up * clean * clean * clean * lint * refactor * refactor * refactor * clean * add axios Co-authored-by: Cassidy Schaufele <cassidyschaufele@gmail.com> Co-authored-by: Kumaraguru Periyasamy Kanthasamy <48932104+GuruPKK@users.noreply.github.com> * pointing to right meta file * Update githubJob.js * Update Dockerfile * Update Dockerfile * Update Dockerfile * Cache purge changes (#435) * Dop 1986: Instantly see changes on docs on /deploy (#422) * testing * testing * testing * save changes * test * commit before switch branch * commit before switch * temp * test * test * test * 5-11-21 Release version bump (#417) * clean up * clean * clean up * clean * clean * clean * lint * refactor * refactor * refactor * clean * add axios Co-authored-by: Cassidy Schaufele <cassidyschaufele@gmail.com> Co-authored-by: Kumaraguru Periyasamy Kanthasamy <48932104+GuruPKK@users.noreply.github.com> * pointing to right meta file * Update githubJob.js * Update Dockerfile * Update Dockerfile Co-authored-by: madelinezec <mez2113@columbia.edu> Co-authored-by: Cassidy Schaufele <cassidyschaufele@gmail.com> * Update S3Publish.js * Update S3Publish.js * Update fastlyJob.js * Update S3Publish.js Co-authored-by: madelinezec <mez2113@columbia.edu> Co-authored-by: Cassidy Schaufele <cassidyschaufele@gmail.com>
GuruPKK
added a commit
that referenced
this pull request
Feb 24, 2022
* Dop 1986: Instantly see changes on docs on /deploy (#422) =
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background on the issue: https://docs.google.com/document/d/1n_KuSuz_4RbCtYR45WT-ormZo5X1RA_r80ioVmfVZFQ/edit
context on implementation: https://docs.google.com/document/d/1IxnFhyTcDVRLBECH6EXQIrc9ksFHTYrFe3biO2ELAQY/edit?usp=sharing