Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Throw error on bigint usage and add helpers to Long #426

Merged
merged 1 commit into from Mar 9, 2021

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 2, 2021

Adds helpers toBigInt and fromBigInt to the Long class to help
support 64bit values. Throws an error when bigint is attempted to
be serialized.

NODE-2378

@nbbeeken nbbeeken requested review from durran and emadum Mar 2, 2021
Adds helpers toBigInt and fromBigInt to the Long class to help
support 64bit values. Throws an error when bigint is attempted to
be serialized.

NODE-2378
@nbbeeken nbbeeken force-pushed the NODE-2378/add-bigint-error branch from 47935a8 to d51cee0 Compare Mar 2, 2021
emadum
emadum approved these changes Mar 4, 2021
Copy link
Contributor

@emadum emadum left a comment

LGTM 👍

durran
durran approved these changes Mar 9, 2021
Copy link
Member

@durran durran left a comment

LGTM

@nbbeeken nbbeeken merged commit 375f368 into 1.0-branch Mar 9, 2021
2 checks passed
@nbbeeken nbbeeken deleted the NODE-2378/add-bigint-error branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants