LG-1719 Add description to radio #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSonOfThomp
added
the
1. New Feature 🚀
|
Size Change: +434 B (0%) Total Size: 829 kB
ℹ️ View Unchanged
|
shaneeza
reviewed
Mar 1, 2023
| & + & { | ||
| margin-top: 8px; | ||
| } | ||
| `; | ||
|
|
||
| export const containerSizeStyle: Omit<Record<Size, string>, 'xsmall'> = { | ||
| [Size.Small]: css` | ||
| grid-template-columns: ${14 + 8}px auto; |
There was a problem hiding this comment.
Where are these numbers coming from?
shaneeza
reviewed
Mar 1, 2023
|
|
||
| {description && ( | ||
| <Description | ||
| className={css` |
There was a problem hiding this comment.
Can we move these styles to .styles?
shaneeza
reviewed
Mar 1, 2023
| </Label> | ||
|
|
||
| {description && ( | ||
| <Description |
There was a problem hiding this comment.
Do we need to add an id to this and pass that to input with aria-describedby?
shaneeza
reviewed
Mar 1, 2023
| /** | ||
| * Description text rendered under the label. | ||
| */ | ||
| description?: string; |
There was a problem hiding this comment.
We can also add this to PropTypes.
shaneeza
reviewed
Mar 1, 2023
| export const containerStyle = css` | ||
| display: grid; | ||
| grid-template-areas: 'label label' '. description'; | ||
|
|
||
| & + & { |
There was a problem hiding this comment.
You could also remove this bit of code and replace with flex and gap. This way, teams can use flex-direction.
There was a problem hiding this comment.
Ah good call!!
shaneeza
reviewed
Mar 1, 2023
shaneeza
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-1719
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes