Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Correctly serialize lock statistics in system.profile. #144
That's really interesting (and surprising) that all of the TimeSpan.FromSomething methods truncate the result to a precision of milliseconds. Thanks for figuring that out!
I think it's OK to have a TimeSpanUnits of Nanoseconds even though the precision of TimeSpans is not that precise. The point of the units is to allow interoperating with interval values from other systems as well, and we want to be able to read TimeSpans from the database even if they happen to be expressed in nanoseconds (knowing that we are going to lose a bit of precision in the process).
FYI, the documentation on the format of the documents in system.profile is pretty scanty. Turns out there are other fields that we didn't know about either, so I'm attempting to get a full definition of this document format and address those as well.
It might make sense to split this up into two tickets, since the nanosecond thing doesn't really have anything to do with the system.profile stuff, it's just something I noticed.
If we forget about the precision issue for a moment, there's still the issue that 1 millisecond = 1.000.000 nanoseconds, but the serializer uses 1 milliseconds = 1.000 nanoseconds. So if you have timespans stored in nanoseconds in the database they will be incorrectly deserialized into a TimeSpan.
About the precision, you can get precision down to a 100 nanoseconds in a TimeSpan, but it depends on which .FromX method you use to initalize the TimeSpan. The timespan uses Ticks where 1 tick = 100 nanoseconds.
So to get the TimeSpan with the best possible precision (100 nanosecond) from nanoseconds you could do
Fixing the 1000 vs 1000000 issue is going to be a breaking change no matter what. I would argue that it would be better to just remove .Nanoseconds as an option, and let people use longs directly if they are storing nanoseconds. But it's not something I care deeply about, just something I noticed and thought was weird :)
I found that in commit 571b5d974f the names were changed (and perhaps the units as well? Don't know if they were always microseconds or if they actually were milliseconds before). I'm guessing that change first came out in 2.2 ?
That makes it a bit tricky to figure out what the right thing to do here is. Go with the new names and drop compatibility with the older versions? Somehow handle both names? We also have an old 1.6 server lying around, and there the system.profile looks completely different, so it seems like the system.profile object is a bit of a moving target to have a concrete class for.