DEVPROD-20053 - Remove perf.send from latest release branch #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
eramongodb
requested changes
Jul 29, 2025
Contributor
eramongodb
left a comment
eramongodb
left a comment
There was a problem hiding this comment.
Thank you very much!
Feedback primarily concerns minor code quality suggestions/improvements.
Comment on lines
+21
to
+22
| http_status=$(echo "$response" | grep "HTTP_STATUS" | awk -F':' '{print $2}') | ||
| response_body=$(echo "$response" | sed '/HTTP_STATUS/d') |
Contributor
There was a problem hiding this comment.
Suggested change
| http_status=$(echo "$response" | grep "HTTP_STATUS" | awk -F':' '{print $2}') | |
| response_body=$(echo "$response" | sed '/HTTP_STATUS/d') | |
| http_status="$(echo "$response" | grep "HTTP_STATUS" | awk -F':' '{print $2}')" | |
| response_body="$(echo "$response" | sed '/HTTP_STATUS/d')" |
SC2086. Also applies to other instances of var=$(...) above.
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
Contributor
Author
Thanks for the suggestions and feedback! I've applied the changes |
eramongodb
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perf.send command is no longer being maintained and will be decommissioned soon. Users can now submit performance data using the "raw_perf_results" end point provided by the performance-monitoring-api. This PR migrates the latest release project over to that API.