v1: pipeline (CXX-3237, CXX-3238) #1513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Nov 20, 2025
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with minor comments.
| scoped_bson{R"({"x": 1, "y": 2})"}, | ||
| })); | ||
|
|
||
| CAPTURE(input); |
Collaborator
There was a problem hiding this comment.
On a failed assert, this capture prints the address:
input := 0x16f6ffef8
Suggest adding a StringMaker implementation for scoped_bson:
template <>
struct Catch::StringMaker<mongocxx::scoped_bson> {
static std::string convert(mongocxx::scoped_bson const& b) {
return Catch::StringMaker<bsoncxx::v1::document::view>::convert(b.view());
}
};Resulting in:
input := {"x": 1}
| /// Convert to the @ref mongocxx::v1 equivalent. | ||
| /// | ||
| /// @par Postconditions: | ||
| /// - `other` is in an assign-or-destroy-only state. |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// - `other` is in an assign-or-destroy-only state. | |
| /// - `this` is in an assign-or-destroy-only state. |
|
|
||
| void append(bsoncxx::v1::document::view doc) { | ||
| _doc += scoped_bson{BCON_NEW(this->idx(), BCON_DOCUMENT(scoped_bson_view{doc}.bson()))}; | ||
| ++_count; |
Collaborator
There was a problem hiding this comment.
Aside: I expect the unchecked ++_count is OK. If a caller were to append INT32_MAX stages, _doc would sooner overflow an result in an exception when appending to _doc.
This was referenced Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3237 and CXX-3238 for the
v1::pipelinecomponent.The
internal::doc()API is used allow direct access to the pipelinescoped_bsondocument byv_noabi::(collection|database)::_aggregate()when callingmongoc_database_aggregate()with abson_t const* pipelineargument. We can consider redefining the_aggregate()function so it builds the pipeline document usingscoped_bsonrather than deferring it to mongoc (which would avoid the need for this internal API), e.g. as currently done inv_noabi::collection::_watch()andclient::_watch()via the basic builder API. However, this PR (initially) proposes making minimal changes to the behavior of unrelated components during the v_noabi refactor of a given component to facilitate easier scoping and review. The current arrangement also helps avoid the need for multiple intermediate temporary (view) objects (pipeline.view_array()->scoped_bson_view()->.bson()).