Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-1911 Pass PYTHON variable to set-temp-creds.sh #603

Merged

Conversation

@divjotarora
Copy link
Collaborator

@divjotarora divjotarora commented Mar 8, 2021

No description provided.

@benjirewis benjirewis self-requested a review Mar 8, 2021
Copy link
Collaborator

@benjirewis benjirewis left a comment

LGTM. Thank you for investigating/fixing!

else
export PYTHON="$(pwd)/venv/bin/python"
fi
Copy link
Collaborator

@benjirewis benjirewis Mar 8, 2021

Ideally, we'd combine the virtual environment creation, python3 binary setting, and boto3 installation into a single call to activate_venv.sh.. But, that unfortunately sets PYTHON_BINARY and not PYTHON, so it wouldn't work perfectly...

Copy link
Collaborator Author

@divjotarora divjotarora Mar 8, 2021

Also, PYTHON3_BINARY points to the system installation of python3, but we actually want to point to the virtualenv python installation here.

Copy link
Collaborator

@benjirewis benjirewis Mar 8, 2021

Ah yep, that too.

@@ -75,8 +75,7 @@ functions:
if [ "Windows_NT" = "$OS" ]; then
mkdir -p c:/libmongocrypt/include
mkdir -p c:/libmongocrypt/bin
# TODO: After a stable libmongocrypt 1.1.0 is released in MONGOCRYPT-293, update this URL to: https://s3.amazonaws.com/mciuploads/libmongocrypt/windows/latest_release/libmongocrypt.tar.gz
curl https://s3.amazonaws.com/mciuploads/libmongocrypt/windows/latest_release/libmongocrypt_unstable.tar.gz --output libmongocrypt.tar.gz
curl https://s3.amazonaws.com/mciuploads/libmongocrypt/windows/latest_release/libmongocrypt.tar.gz --output libmongocrypt.tar.gz
Copy link
Collaborator

@benjirewis benjirewis Mar 8, 2021

Nice, looks like there was a TODO all along.

iwysiu
iwysiu approved these changes Mar 8, 2021
@divjotarora divjotarora merged commit cd38cbc into mongodb:master Mar 8, 2021
34 of 36 checks passed
@divjotarora divjotarora deleted the godriver1911-set-creds-failures branch Mar 8, 2021
divjotarora added a commit that referenced this issue Mar 8, 2021
This commit addresses two failures that started showing up after GODRIVER-1855:

- Set the PYTHON environment variable to point to the local python3 installation before calling set-temp-creds.sh
- For Windows tasks, update the libmongocrypt URL to install the latest stable version (v1.2.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants