Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-1911 Pass PYTHON variable to set-temp-creds.sh #603

Merged

Conversation

divjotarora
Copy link
Collaborator

No description provided.

@benjirewis benjirewis self-requested a review March 8, 2021 19:05
Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for investigating/fixing!

else
export PYTHON="$(pwd)/venv/bin/python"
fi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we'd combine the virtual environment creation, python3 binary setting, and boto3 installation into a single call to activate_venv.sh.. But, that unfortunately sets PYTHON_BINARY and not PYTHON, so it wouldn't work perfectly...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, PYTHON3_BINARY points to the system installation of python3, but we actually want to point to the virtualenv python installation here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yep, that too.

@@ -75,8 +75,7 @@ functions:
if [ "Windows_NT" = "$OS" ]; then
mkdir -p c:/libmongocrypt/include
mkdir -p c:/libmongocrypt/bin
# TODO: After a stable libmongocrypt 1.1.0 is released in MONGOCRYPT-293, update this URL to: https://s3.amazonaws.com/mciuploads/libmongocrypt/windows/latest_release/libmongocrypt.tar.gz
curl https://s3.amazonaws.com/mciuploads/libmongocrypt/windows/latest_release/libmongocrypt_unstable.tar.gz --output libmongocrypt.tar.gz
curl https://s3.amazonaws.com/mciuploads/libmongocrypt/windows/latest_release/libmongocrypt.tar.gz --output libmongocrypt.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like there was a TODO all along.

iwysiu
iwysiu approved these changes Mar 8, 2021
@divjotarora divjotarora merged commit cd38cbc into mongodb:master Mar 8, 2021
34 of 36 checks passed
@divjotarora divjotarora deleted the godriver1911-set-creds-failures branch March 8, 2021 20:25
divjotarora added a commit that referenced this pull request Mar 8, 2021
This commit addresses two failures that started showing up after GODRIVER-1855:

- Set the PYTHON environment variable to point to the local python3 installation before calling set-temp-creds.sh
- For Windows tasks, update the libmongocrypt URL to install the latest stable version (v1.2.0)
This was referenced Mar 10, 2021
faem pushed a commit to kubedb/mongo-go-driver that referenced this pull request Mar 17, 2022
This commit addresses two failures that started showing up after GODRIVER-1855:

- Set the PYTHON environment variable to point to the local python3 installation before calling set-temp-creds.sh
- For Windows tasks, update the libmongocrypt URL to install the latest stable version (v1.2.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants