https://jira.mongodb.org/browse/JAVA-375 #54

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@Shekharv

Take a look at this. i wanted you guys to take a look before i did too much.

Shekharv added some commits Dec 13, 2011
@Shekharv Shekharv https://jira.mongodb.org/browse/JAVA-375
first set of changes.
1.) Most classes now use their canonical name to register the logger so that the log entries will be more consistent and we can enable disable logging on a package level too as opposed to having to go against dynamic logger names.
2.) changed/fixed a test case. DBCursorTest. added cur.next() so that the find() query will actually get some data.

a couple of TODOs that still need to fixed in another pass.
6871a29
@Shekharv Shekharv https://jira.mongodb.org/browse/JAVA-375
Removing some TODOs. At this point ReplicaSetStatus is the only one that still needs to be fixed.
bff1ce2
@rgnitz

Can you pull this cur.next() out (and the other one). We have modified getServerAddress() to solve this problem in master. Thx.

@Shekharv Shekharv https://jira.mongodb.org/browse/JAVA-375
Removing the cur.next in two testcases from DBCursorTest
f3070f5
@Shekharv

Done.

@Shekharv

so, what's next?

@Shekharv
Shekharv commented Jan 6, 2012

any comments?

@jyemin
Contributor
jyemin commented Dec 30, 2012

I consider logger name changes to be backwards breaking, so tabling this until 3.0 release.

@jyemin jyemin closed this Dec 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment