Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 0 maxSize in DefaultConnectionPool and allow passing 0 to MongoClientOptions.Builder.maxSize #769

Merged
merged 2 commits into from Jul 29, 2021

Conversation

stIncMale
Copy link
Member

…ongoClientOptions.Builder.maxSize`

JAVA-4216
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after unit test added

@stIncMale stIncMale requested a review from jyemin July 28, 2021 22:26
@stIncMale
Copy link
Member Author

This test failure is the same as reported in JAVA-4259.

Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stIncMale stIncMale merged commit d1d7b07 into mongodb:master Jul 29, 2021
@stIncMale stIncMale deleted the JAVA-4216 branch July 29, 2021 18:09
ispringer pushed a commit to evergage/mongo-java-driver that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants