Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed a couple of test names to be (mostly) consistent. #440

Merged
merged 1 commit into from

3 participants

@derickr
Owner

No description provided.

@jmikola jmikola commented on the diff
tests/generic/stream-logger-batchinsert-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-Stream Logger: log_batchinsert() #001
+Stream Logger: log_batchinsert() (1)
@jmikola Owner
jmikola added a note

Appending "(1)" seems to add little value, as the test execution output already includes the filename. If necessary, these should just describe the aspect of the subject being tested. If there is only 001, it may be testing everything so the explanation may not even be necessary.

@derickr Owner
derickr added a note

Right,some of those can definitely be improved more. Feel free to make a PR if you have some spare time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@bjori
Owner

I always run the tests with SHOW_ONLY_GROUPS=SKIP,FAIL so don't care either way.
LGTM

@derickr derickr referenced this pull request from a commit
@derickr derickr Merged pull request #440 2bf5354
@derickr derickr merged commit aa5f369 into mongodb:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 26 additions and 26 deletions.
  1. +1 −1  tests/auth-replicaset/legacy/bug00629.phpt
  2. +1 −1  tests/generic/bug00746.phpt
  3. +1 −1  tests/generic/connection-fork-001.phpt
  4. +1 −1  tests/generic/connection-fork-002.phpt
  5. +1 −1  tests/generic/mongoclient-ctor-readPref-001.phpt
  6. +1 −1  tests/generic/stream-logger-batchinsert-001.phpt
  7. +1 −1  tests/generic/stream-logger-getmore-001.phpt
  8. +1 −1  tests/generic/stream-logger-killcursor-001.phpt
  9. +1 −1  tests/mongos/mongoclient-construct-001.phpt
  10. +1 −1  tests/mongos/mongoclient-construct-002.phpt
  11. +1 −1  tests/mongos/read-preferences-001.phpt
  12. +1 −1  tests/mongos/stream-logger-001.phpt
  13. +1 −1  tests/no-servers/bug00407.phpt
  14. +1 −1  tests/replicaset-failover/mongoclient-construct-001.phpt
  15. +1 −1  tests/replicaset-failover/mongoclient-construct-002.phpt
  16. +1 −1  tests/replicaset-failover/mongoclient-construct-003.phpt
  17. +1 −1  tests/replicaset-failover/mongocollection-insert-001.phpt
  18. +1 −1  tests/replicaset/legacy/mongocursor-setreadpreference-001.phpt
  19. +1 −1  tests/replicaset/legacy/mongocursor-setreadpreference-002.phpt
  20. +1 −1  tests/replicaset/legacy/mongocursor-setreadpreference-003.phpt
  21. +1 −1  tests/replicaset/mongoclient-construct-001.phpt
  22. +1 −1  tests/replicaset/mongoclient-construct-002.phpt
  23. +1 −1  tests/replicaset/mongoclient-construct-003.phpt
  24. +1 −1  tests/standalone/legacy/bug00522_error.phpt
  25. +1 −1  tests/standalone/legacy/bug00644-001.phpt
  26. +1 −1  tests/standalone/legacy/bug00644-002.phpt
View
2  tests/auth-replicaset/legacy/bug00629.phpt
@@ -1,5 +1,5 @@
--TEST--
-Test for PHP-629
+Test for PHP-629: Missing support for passing the username/password in the $options array
--SKIPIF--
<?php require_once "tests/utils/auth-replicaset.inc" ?>
--FILE--
View
2  tests/generic/bug00746.phpt
@@ -1,5 +1,5 @@
--TEST--
-PHP-746: The getBytes method may return random data in particular conditions.
+Test for PHP-746: The getBytes method may return random data in particular conditions.
--SKIPIF--
<?php require "tests/utils/standalone.inc";?>
--FILE--
View
2  tests/generic/connection-fork-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-Test for forking and connection management [1]
+Test for forking and connection management (1)
--SKIPIF--
<?php require_once "tests/utils/standalone.inc"; ?>
<?php if (!function_exists("pcntl_fork")) { exit("skip Requires ext/pcntl"); }?>
View
2  tests/generic/connection-fork-002.phpt
@@ -1,5 +1,5 @@
--TEST--
-Test for forking and connection management [2]
+Test for forking and connection management (2)
--SKIPIF--
<?php require_once "tests/utils/standalone.inc"; ?>
<?php if (!function_exists("pcntl_fork")) { exit("skip Requires ext/pcntl"); }?>
View
2  tests/generic/mongoclient-ctor-readPref-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-Connection strings: read preferences [1]
+Connection strings: read preferences (1)
--SKIPIF--
<?php require_once "tests/utils/standalone.inc" ?>
--FILE--
View
2  tests/generic/stream-logger-batchinsert-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-Stream Logger: log_batchinsert() #001
+Stream Logger: log_batchinsert() (1)
@jmikola Owner
jmikola added a note

Appending "(1)" seems to add little value, as the test execution output already includes the filename. If necessary, these should just describe the aspect of the subject being tested. If there is only 001, it may be testing everything so the explanation may not even be necessary.

@derickr Owner
derickr added a note

Right,some of those can definitely be improved more. Feel free to make a PR if you have some spare time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
--SKIPIF--
<?php require_once "tests/utils/standalone.inc" ?>
--FILE--
View
2  tests/generic/stream-logger-getmore-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-Stream Logger: log_getmore() #001
+Stream Logger: log_getmore() (1)
--SKIPIF--
<?php require_once "tests/utils/standalone.inc" ?>
--FILE--
View
2  tests/generic/stream-logger-killcursor-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-Stream Logger: log_killcursor() #001
+Stream Logger: log_killcursor() (1)
--SKIPIF--
<?php require_once "tests/utils/standalone.inc" ?>
--FILE--
View
2  tests/mongos/mongoclient-construct-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::__construct()#001 Connecting to one mongos
+MongoClient::__construct(): Connecting to one mongos (1)
--SKIPIF--
<?php require_once "tests/utils/mongos.inc" ?>
--FILE--
View
2  tests/mongos/mongoclient-construct-002.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::__construct()#001 Connecting to multiple mongos
+MongoClient::__construct(): Connecting to multiple mongos (2)
--SKIPIF--
<?php require_once "tests/utils/mongos.inc" ?>
--FILE--
View
2  tests/mongos/read-preferences-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-Read Preferences over mongos #001
+Read Preferences over mongos (1)
--SKIPIF--
<?php require_once "tests/utils/mongos.inc" ?>
--FILE--
View
2  tests/mongos/stream-logger-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::__construct()#001 Connecting to one mongos
+MongoClient::__construct(): Connecting to one mongos (1)
--SKIPIF--
<?php require_once "tests/utils/mongos.inc" ?>
--FILE--
View
2  tests/no-servers/bug00407.phpt
@@ -1,5 +1,5 @@
--TEST--
-Test for PHP-407 MongoBinData should default to 0, not 2.
+Test for PHP-407: MongoBinData should default to 0, not 2.
--SKIPIF--
<?php require_once dirname(__FILE__) ."/skipif.inc"; ?>
--FILE--
View
2  tests/replicaset-failover/mongoclient-construct-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::__construct()#001 during failover
+MongoClient::__construct() during failover (1)
--SKIPIF--
<?php require_once "tests/utils/replicaset-failover.inc" ?>
--FILE--
View
2  tests/replicaset-failover/mongoclient-construct-002.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::__construct()#002 during failover
+MongoClient::__construct() during failover (2)
--SKIPIF--
<?php require_once "tests/utils/replicaset-failover.inc" ?>
--FILE--
View
2  tests/replicaset-failover/mongoclient-construct-003.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::__construct()#003 during failover
+MongoClient::__construct() during failover (3)
--SKIPIF--
<?php require_once "tests/utils/replicaset-failover.inc" ?>
--FILE--
View
2  tests/replicaset-failover/mongocollection-insert-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::insert()#001 during failover
+MongoClient::insert() during failover (1)
--SKIPIF--
<?php require_once "tests/utils/replicaset-failover.inc" ?>
--FILE--
View
2  tests/replicaset/legacy/mongocursor-setreadpreference-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoCursor::setReadPreference [1]
+MongoCursor::setReadPreference (1)
--SKIPIF--
<?php if (version_compare(phpversion(), "5.3.0", "lt")) exit("skip setCallback and closures are 5.3+"); ?>
<?php require_once "tests/utils/replicaset.inc"; ?>
View
2  tests/replicaset/legacy/mongocursor-setreadpreference-002.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoCursor::setReadPreference (first setReadPreference, then slaveOkay) [2]
+MongoCursor::setReadPreference (first setReadPreference, then slaveOkay) (2)
--SKIPIF--
<?php if (version_compare(phpversion(), "5.3.0", "lt")) exit("skip setCallback and closures are 5.3+"); ?>
<?php require_once "tests/utils/replicaset.inc"; ?>
View
2  tests/replicaset/legacy/mongocursor-setreadpreference-003.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoCursor::setReadPreference (first slaveOkay, then setReadPreference) [3]
+MongoCursor::setReadPreference (first slaveOkay, then setReadPreference) (3)
--SKIPIF--
<?php if (version_compare(phpversion(), "5.3.0", "lt")) exit("skip setCallback and closures are 5.3+"); ?>
<?php require_once "tests/utils/replicaset.inc"; ?>
View
2  tests/replicaset/mongoclient-construct-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::__construct()#001 Connecting to replicaset
+MongoClient::__construct(): Connecting to replicaset (1)
--SKIPIF--
<?php require_once "tests/utils/replicaset.inc" ?>
--FILE--
View
2  tests/replicaset/mongoclient-construct-002.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::__construct()#002 Connecting to replicaset using only one node
+MongoClient::__construct(): Connecting to replicaset using only one node (2)
--SKIPIF--
<?php require_once "tests/utils/replicaset.inc" ?>
--FILE--
View
2  tests/replicaset/mongoclient-construct-003.phpt
@@ -1,5 +1,5 @@
--TEST--
-MongoClient::__construct()#003 Connecting to replicaset member in a standalone mode
+MongoClient::__construct(): Connecting to replicaset member in a standalone mode (3)
--SKIPIF--
<?php require_once "tests/utils/replicaset.inc" ?>
--FILE--
View
2  tests/standalone/legacy/bug00522_error.phpt
@@ -1,5 +1,5 @@
--TEST--
-Test for PHP-522_error: Checking error conditions in insert options
+Test for PHP-522: Checking error conditions in insert options
--SKIPIF--
<?php require_once "tests/utils/standalone.inc";?>
--FILE--
View
2  tests/standalone/legacy/bug00644-001.phpt
@@ -1,5 +1,5 @@
--TEST--
-Test for bug #644: mongo.ping_interval and mongo.is_master_interval is unused. (1)
+Test for PHP-644: mongo.ping_interval and mongo.is_master_interval is unused (1)
--SKIPIF--
<?php require_once "tests/utils/standalone.inc"; ?>
--INI--
View
2  tests/standalone/legacy/bug00644-002.phpt
@@ -1,5 +1,5 @@
--TEST--
-Test for bug #644: mongo.ping_interval and mongo.is_master_interval is unused. (2)
+Test for PHP-644: mongo.ping_interval and mongo.is_master_interval is unused (2)
--SKIPIF--
<?php require_once "tests/utils/standalone.inc"; ?>
--INI--
Something went wrong with that request. Please try again.