Split out WriteConcern constructor error test and skip for HHVM #74

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@derickr
mongodb member

https://jira.mongodb.org/browse/PHPC-129

I am adding an equivalent test to the HHVM suite, that is going to be skipped by non-HHVM.

@bjori
mongodb member

Can you amend the commit and add PHPC-129 to it?

Also, I thought HHVM couldn't throw exception at all - as per PHPC-129 ?

@jmikola jmikola changed the title from Split erroring part of test out into new file, and ignore with HHVM to Split out WriteConcern constructor error test and skip for HHVM Aug 6, 2015
@jmikola
mongodb member

Rebased as b31ad7c and manually merged in c4d0342.

@jmikola jmikola closed this Aug 6, 2015
@jmikola jmikola added a commit to jmikola/mongo-php-driver that referenced this pull request Aug 7, 2015
@jmikola jmikola Split out Manager constructor error tests
The extra arguments test can be skipped for HHVM (as was done in #74).

The read preference and write concern tests attempt to cover all permutations of invalid arguments. Detailed exceptions are only possible where we apply array options to the structures, since libmongoc currently provides no detailed errors when URI parsing fails (see: CDRIVER-782).
1e9766b
@jmikola jmikola added a commit to jmikola/mongo-php-driver that referenced this pull request Aug 13, 2015
@jmikola jmikola Split out Manager constructor error tests
The extra arguments test can be skipped for HHVM (as was done in #74).

The read preference and write concern tests attempt to cover all permutations of invalid arguments. Detailed exceptions are only possible where we apply array options to the structures, since libmongoc currently provides no detailed errors when URI parsing fails (see: CDRIVER-782).
960c51a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment