Fix uri_parser read_preference validation #152

Closed
wants to merge 2 commits into from

3 participants

@craigahobbs

uri_parser fails if there is a read_preference option. This fixes that.

@rozza
mongodb member

Thanks Craig - I've added https://jira.mongodb.org/browse/PYTHON-471 for this pull request for review.

@behackett
mongodb member

Hi Craig,

Thanks for this pull request. Using read preferences with the MongoDB URI seems totally broken currently. :(
The only thing this is missing is support for 'readPreference' which is what the URI option is really called. If you want to add that (it's just adding another entry to common.VALIDATORS) great. Otherwise I can do it after merging this.

@behackett
mongodb member

Perfect. Thanks again for the patch. Merged just in time for 2.4.2.

@behackett behackett closed this Jan 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment