From 99ea7398c8021ab06f978f7e321e6d62fe429923 Mon Sep 17 00:00:00 2001 From: Iris Ho Date: Tue, 23 Sep 2025 16:09:23 -0700 Subject: [PATCH 1/7] create pull request template (not sure why uv lock changed) --- .github/PULL_REQUEST_TEMPLATE.md | 32 ++++++++++++++++++++++++++++++++ uv.lock | 2 +- 2 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000..ae9764dc5d --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,32 @@ + +## Summary +_What conceptually is this PR introducing? If context is already provided from the JIRA ticket, still place it in the +Pull Request as you should not make the reviewer do digging for a basic summary._ + +## Changes in this PR +_What changes did you make to the code? What new APIs (public or private) were added, removed, or edited to generate +the desired outcome explained in the above summary?_ + +## Test Plan +_How did you test the code? If you added unit tests, you can say that. If you didn’t introduce unit tests, explain why. +All code should be tested in some way – so please list what your validation strategy was._ + +### Screenshots (optional) +_Usually a great supplement to a test plan, especially if this requires local testing._ + +## Checklist +### Checklist for Author +- [ ] Did you update the changelog (if necessary)? +- [ ] Is the intention of the code captured in relevant tests? +- [ ] If there are new TODOs, has a related JIRA ticket been created? + +### Checklist for Reviewer {@primary_reviewer} +- [ ] Does the title of the PR reference a JIRA Ticket? +- [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) +- [ ] Have you checked for spelling & grammar errors? +- [ ] Is all relevant documentation (README or docstring) updated? + +## Focus Areas for Reviewer +_List any complex portion of code you believe needs additional scrutiny and explain why._ + + diff --git a/uv.lock b/uv.lock index 5a7279e1ef..ce0367e872 100644 --- a/uv.lock +++ b/uv.lock @@ -1309,7 +1309,7 @@ requires-dist = [ { name = "furo", marker = "extra == 'docs'", specifier = "==2025.7.19" }, { name = "importlib-metadata", marker = "python_full_version < '3.13' and extra == 'test'", specifier = ">=7.0" }, { name = "pykerberos", marker = "os_name != 'nt' and extra == 'gssapi'" }, - { name = "pymongo-auth-aws", marker = "extra == 'aws'", specifier = ">=1.1.1,<2.0.0" }, + { name = "pymongo-auth-aws", marker = "extra == 'aws'", specifier = ">=1.1.0,<2.0.0" }, { name = "pymongo-auth-aws", marker = "extra == 'encryption'", specifier = ">=1.1.0,<2.0.0" }, { name = "pymongocrypt", marker = "extra == 'encryption'", specifier = ">=1.13.0,<2.0.0" }, { name = "pyopenssl", marker = "extra == 'ocsp'", specifier = ">=17.2.0" }, From eb65cc0f9d10b3fb66100c47909f09d86701909e Mon Sep 17 00:00:00 2001 From: Iris Ho Date: Mon, 29 Sep 2025 10:49:10 -0700 Subject: [PATCH 2/7] change section descriptions to be comments to the PR author --- .github/PULL_REQUEST_TEMPLATE.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ae9764dc5d..7cf2e482b0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,20 +1,21 @@ ## Summary -_What conceptually is this PR introducing? If context is already provided from the JIRA ticket, still place it in the -Pull Request as you should not make the reviewer do digging for a basic summary._ + ## Changes in this PR -_What changes did you make to the code? What new APIs (public or private) were added, removed, or edited to generate -the desired outcome explained in the above summary?_ + ## Test Plan -_How did you test the code? If you added unit tests, you can say that. If you didn’t introduce unit tests, explain why. -All code should be tested in some way – so please list what your validation strategy was._ + ### Screenshots (optional) -_Usually a great supplement to a test plan, especially if this requires local testing._ + ## Checklist + ### Checklist for Author - [ ] Did you update the changelog (if necessary)? - [ ] Is the intention of the code captured in relevant tests? @@ -27,6 +28,6 @@ _Usually a great supplement to a test plan, especially if this requires local te - [ ] Is all relevant documentation (README or docstring) updated? ## Focus Areas for Reviewer -_List any complex portion of code you believe needs additional scrutiny and explain why._ + From f9b42155e0bb1113f869d359c3ca9dfd935eae96 Mon Sep 17 00:00:00 2001 From: Iris Ho Date: Tue, 30 Sep 2025 11:46:31 -0700 Subject: [PATCH 3/7] rename to lowercase? --- .github/{PULL_REQUEST_TEMPLATE.md => pull_request_template.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{PULL_REQUEST_TEMPLATE.md => pull_request_template.md} (100%) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/pull_request_template.md similarity index 100% rename from .github/PULL_REQUEST_TEMPLATE.md rename to .github/pull_request_template.md From 2fde260a22af4c2d387d5c3e8efc671144d2c34a Mon Sep 17 00:00:00 2001 From: Iris Ho Date: Thu, 2 Oct 2025 10:30:36 -0700 Subject: [PATCH 4/7] add issue key to top of template and 'test' -> 'testing' --- .github/pull_request_template.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 7cf2e482b0..f71bc1beb3 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,5 @@ +[Issue Key](https://jira.mongodb.org/browse/%7BISSUE_KEY%7D) ## Summary @@ -7,7 +8,7 @@ Pull Request as you should not make the reviewer do digging for a basic summary. -## Test Plan +## Testing Plan From a0a547cb1a963830a3ccc7408cade62fa352ae61 Mon Sep 17 00:00:00 2001 From: Iris Ho Date: Thu, 2 Oct 2025 11:48:17 -0700 Subject: [PATCH 5/7] remove old template --- .github/workflows/pull_request_template.md | 23 ---------------------- 1 file changed, 23 deletions(-) delete mode 100644 .github/workflows/pull_request_template.md diff --git a/.github/workflows/pull_request_template.md b/.github/workflows/pull_request_template.md deleted file mode 100644 index 852066d4b2..0000000000 --- a/.github/workflows/pull_request_template.md +++ /dev/null @@ -1,23 +0,0 @@ -# [JIRA Ticket ID](Link to Ticket) - - -# Summary - - -# Changes in this PR - - -# Test Plan - - -# Screenshots (Optional) - - -# Callouts or Follow-up items (Optional) - From 55bcc69b4c1f4f0c1b3602a5d472230751dfe232 Mon Sep 17 00:00:00 2001 From: Iris Ho Date: Thu, 2 Oct 2025 14:29:53 -0700 Subject: [PATCH 6/7] add blurb about PR title format and make focus area optional --- .github/pull_request_template.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f71bc1beb3..4fe62b2b3d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,10 @@ + [Issue Key](https://jira.mongodb.org/browse/%7BISSUE_KEY%7D) ## Summary From f5a727c21b1e2ba8ac456b3d15a51588c3ae838c Mon Sep 17 00:00:00 2001 From: Iris Ho Date: Mon, 6 Oct 2025 10:05:46 -0700 Subject: [PATCH 7/7] remove link to PR template google doc --- .github/pull_request_template.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4fe62b2b3d..8185a38836 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -36,5 +36,3 @@ All code should be tested in some way – so please list what your validation st ## Focus Areas for Reviewer (optional) - -