Fall back to sha1 if md5 is not available #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In FIPS mode, md5 is not available. In such cases, fall back to sha1. See https://docs.python.org/3/library/hashlib.html for more info. This is needed for https://jira.mongodb.org/browse/PYTHON-1520.
|
Thanks for the pull request. We're currently planning a change to all drivers to avoid this problem and it likely won't involve sha1, which will almost certainly be banned by FIPS in the future. Whatever change we make will happen in PyMongo's next release. Follow https://jira.mongodb.org/browse/PYTHON-1521 (or https://jira.mongodb.org/browse/PYTHON-1520) for updates. |
|
@daviddavis - I've resolved https://jira.mongodb.org/browse/PYTHON-1521. We've switched to using FNV-1a, a non-cryptographic hash avoiding FIPS issues now and in the future. |
|
@behackett awesome. thank you for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FIPS mode, md5 is not available. In such cases, fall back to sha1.
See https://docs.python.org/3/library/hashlib.html for more info.
This change is based on something similar to what celery
did.
This is needed for https://jira.mongodb.org/browse/PYTHON-1520.