New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-2345 Ensure release files can be installed #487
Conversation
https://evergreen.mongodb.com/version/5f6145e1562343460ae4523e + /System/Library/Frameworks/Python.framework/Versions/2.7/bin/python setup.py bdist_wheel /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'python_requires' warnings.warn(msg) usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] or: setup.py --help [cmd1 cmd2 ...] or: setup.py --help-commands or: setup.py cmd --help error: invalid command 'bdist_wheel'
This reverts commit dcf931f.
@@ -9,7 +17,27 @@ for VERSION in 2.7 3.4 3.5 3.6 3.7 3.8; do | |||
PYTHON=/Library/Frameworks/Python.framework/Versions/$VERSION/bin/python3 | |||
fi | |||
rm -rf build | |||
$PYTHON setup.py bdist_wheel | |||
|
|||
# Install wheel if not already there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed to fix this error:
+ /System/Library/Frameworks/Python.framework/Versions/2.7/bin/python setup.py bdist_wheel
/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'python_requires'
warnings.warn(msg)
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help
error: invalid command 'bdist_wheel'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a FIXME/TODO in case this is expected to be fixed by an upcoming BUILD ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I opened https://jira.mongodb.org/browse/PYTHON-2375 and https://jira.mongodb.org/browse/BUILD-11842. Since it's tracked in Jira I don't think we need to add a TODO in code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! I love the addition of .evergreen/utils.sh - I am optimistic that it will mean more reused code in the future.
Just one question - why don't we test with PyPy as well?
@@ -9,7 +17,27 @@ for VERSION in 2.7 3.4 3.5 3.6 3.7 3.8; do | |||
PYTHON=/Library/Frameworks/Python.framework/Versions/$VERSION/bin/python3 | |||
fi | |||
rm -rf build | |||
$PYTHON setup.py bdist_wheel | |||
|
|||
# Install wheel if not already there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a FIXME/TODO in case this is expected to be fixed by an upcoming BUILD ticket?
I don't test pypy here because we don't publish wheels for pypy. Pypy users will install from the .tar.gz |
Tested here: https://evergreen.mongodb.com/version/5f61533de3c3314c4c6884ff