PYTHON-2678 Resync SRV spec tests #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for validating parsed_options and running non-TLS tests.
test/test_dns.py
Outdated
| opts['readPreferenceTags'] = rpts | ||
| self.assertEqual(result['options'], options) | ||
| if parsed_options: | ||
| for opt in parsed_options: |
Contributor
There was a problem hiding this comment.
Nit: might it be better style to get the key AND value at once from parsed_options?
for opt, expected in parsed_options.items():
...
| if hostname == 'localhost': | ||
| copts = client_context.default_client_options.copy() | ||
| # Remove tls since SRV parsing should add it automatically. | ||
| copts.pop('tls', None) |
Contributor
There was a problem hiding this comment.
Doesn't this pose another problem? Since kwargs override opts passed in the URI, we might be overriding what the test wants to pass? Should we check the keys in result to ensure that none of them matches keys in copts?
Member
Author
There was a problem hiding this comment.
The only test that does this is the ssl=false test which is handled by the needs_tls logic above. So I don't think there's any issue here.
prashantmital
approved these changes
May 4, 2021
ShaneHarvey
added a commit
that referenced
this pull request
May 4, 2021
Add support for validating parsed_options and running non-TLS tests. (cherry picked from commit 0535f5d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for validating parsed_options and running non-TLS tests.
This implements the following (ancient) spec changes which never has drivers tickets created for them: