Support comments on commands #140

merged 2 commits into from Dec 6, 2012


None yet

2 participants


This branch adds support for comments on commands, and adds an option to counts and all the aggregate queries.

nelhage added some commits Dec 6, 2012
@nelhage nelhage Support comments on commands.
Pass these through to the underlying query against the command
@nelhage nelhage Support comments on counts and various aggregate queries. 7e15f97

Thanks @nelhage

Going forward, please squash your commits on each of these pull requests into a single commit. It makes it easier to review on our end. If it doesn't make sense to combine into a single commit then they should probably be submitted as separate pull requests.


Will do. IME different groups have different preferences and so I tend to err on the side of more commits, but I am happy to comply with local conventions.


Thanks, appreciate the help. Everyone is definitely different regarding what they prefer in that respect and we actually don't ask for it in our file yet (but we should).

This specific pull request is actually fine, but when there are a half a dozen or more commits in a single pull request its kind of hard to sift through and it's easier if they're squashed ahead of time.

@brandonblack brandonblack merged commit 97d4855 into mongodb:master Dec 6, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment