Support for GridFS append mode #155

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@alor

alor commented Feb 6, 2013

This change add the ability to open a gridfs file in append mode and add data to it, without having to pull it from the db and put it back once modified.

Currently the only way to append some data to a file is to dump the entire file to a temporary file, append the data and then put it again into the gridfs, a very expensive way to add some bytes to a file.

Hope it will be useful to everyone.

best regards.

@alor

This comment has been minimized.

Show comment Hide comment
@alor

alor Feb 6, 2013

now it's working under ruby 1.8.7 but the test fails for a connection timeout in other part of the code, I suppose it's not my fault. can you check it please?

alor commented Feb 6, 2013

now it's working under ruby 1.8.7 but the test fails for a connection timeout in other part of the code, I suppose it's not my fault. can you check it please?

@brandonblack

This comment has been minimized.

Show comment Hide comment
@brandonblack

brandonblack Feb 13, 2013

Contributor

Thanks @alor.

We're not going to include this in the next release for now and I'm going to go ahead and close out the PR, but I'm going to keep your changes around so it can be discussed with some of the other driver teams at 10gen. Right now, none of the other drivers offer this functionality yet and the Ruby driver shouldn't break the mold here.

We'll need to come to some sort of consensus as a group about whether or not this behavior/functionality should be included before the Ruby driver can proceed so I'm tabling this one for now.

Contributor

brandonblack commented Feb 13, 2013

Thanks @alor.

We're not going to include this in the next release for now and I'm going to go ahead and close out the PR, but I'm going to keep your changes around so it can be discussed with some of the other driver teams at 10gen. Right now, none of the other drivers offer this functionality yet and the Ruby driver shouldn't break the mold here.

We'll need to come to some sort of consensus as a group about whether or not this behavior/functionality should be included before the Ruby driver can proceed so I'm tabling this one for now.

@alor

This comment has been minimized.

Show comment Hide comment
@alor

alor Feb 13, 2013

thank you, let me know if the proposal is accepted. IMHO is a good feature to have in all the drivers and it does not require too much effort to include.

alor commented Feb 13, 2013

thank you, let me know if the proposal is accepted. IMHO is a good feature to have in all the drivers and it does not require too much effort to include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment