Always get primary pool with a sharded client. (RUBY-542) #156

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

durran commented Feb 7, 2013

In the case of a sharded client, all of our nodes that are provided
should be mongos nodes, and thus all should be primary. The read
preference thusly is not handled by the driver, but by the mongos server
and all read operations should pass through the primary mongos.

The case where we have multiple mongos is not handled here, as the
driver does not currently support having multiple primary nodes
configured. I've put a TODO in ReadPreference to indicate this, the question
is whether or not this is something that should be done or not.

[ RUBY-542 ]

Contributor

brandonblack commented Feb 7, 2013

Great work. LGTM.

Contributor

durran commented Feb 7, 2013

Can you email me the info for to the jenkins server?

@durran durran Always get primary pool with a sharded client.
In the case of a sharded client, all of our nodes that are provided
should be mongos nodes, and thus all should be primary. The read
preference thusly is not handled by the driver, but by the mongos server
and all read operations should pass through the primary mongos.

The case where we have multiple mongos is not handled here, as the
driver does not currently support having multiple primary nodes
configured.

[ RUBY-542 ]
fa63b5f
Contributor

brandonblack commented Feb 7, 2013

There's actually a badge in the README here on github, but you can get to it here:
https://jenkins.10gen.com/job/mongo-ruby-driver/

Contributor

durran commented Feb 7, 2013

Was there a reason not to merge, or should I merge myself?

Contributor

brandonblack commented Feb 7, 2013

@durran my apologies I thought you had pushed this already. I thought for some reason this didn't close itself. Go ahead and push from your fork, I was just avoiding the merge button here.

brandonblack reopened this Feb 7, 2013

Contributor

durran commented Feb 7, 2013

Yeah I understand the merge button avoidance. :) Just didn't know if we merge ourselves or if someone else has the final say. I am pulling in now.

durran closed this Feb 7, 2013

Contributor

gjmurakami-10gen commented Feb 7, 2013

We're all empowered at this time, so please forge ahead. If there's an issue, we let each other know, discuss, revert, fix, etc. On tickets, I like the practice and you resolve as soon as it is done, but someone else reviews and closes the ticket.

Contributor

brandonblack commented Feb 7, 2013

Should we have some sort of celebration here for his first closed issue since joining the team? ;-)

Contributor

durran commented Feb 7, 2013

No celebration until this bad-boy is the flagship of the 10gen drivers.

Contributor

brandonblack commented Feb 7, 2013

@durran that sir, is the correct mentality. lets kill it

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment