Validate client options. Related to MONGOID-4157 #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Just a thought - when invalid options are provided in a URI, we log it. I think for consistency it might be good to do it here as well. |
estolfo
force-pushed
the
client-opts
branch
2 times, most recently
from
696a80e to
d7f8e7e
Compare
Contributor
Author
|
@durran done |
Member
|
👍 |
lib/mongo/client.rb
Outdated
Member
There was a problem hiding this comment.
I'd do a 2 space indent here as it's standard formatting in Ruby, and then freeze the array.
Contributor
Author
There was a problem hiding this comment.
sorry, my ide puts in that spacing automatically. I'll update it.
estolfo
added a commit
that referenced
this pull request
Oct 12, 2015
Validate client options. Related to MONGOID-4157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.