Skip to content

Commit

Permalink
SERVER-54572 Introduce assumes_standalone_mongod tag for jscore tests
Browse files Browse the repository at this point in the history
  • Loading branch information
toto-dev authored and Evergreen Agent committed Feb 22, 2021
1 parent 914e04e commit cc4854a
Show file tree
Hide file tree
Showing 53 changed files with 100 additions and 293 deletions.
Expand Up @@ -6,10 +6,6 @@ selector:
exclude_files:
# Don't run these tests as transactions can only run on primaries.
- jstests/core/txns/**/*.js
# Cannot specify afterClusterTime and afterOpTime.
- jstests/core/read_after_optime.js
# Not expected to pass with replica-sets.
- jstests/core/opcounters_write_cmd.js
# Has conditional logic for standalone servers and replica sets, but can't distinguish the two
# when connected to mongos.
- jstests/core/write_result.js
Expand All @@ -19,13 +15,11 @@ selector:
- jstests/core/apply_ops*.js # applyOps, SERVER-1439.
- jstests/core/capped_convertToCapped1.js # cloneCollectionAsCapped.
- jstests/core/capped_empty.js # emptycapped.
- jstests/core/capped_update.js # uses godinsert and can't run under replication.
- jstests/core/check_shard_index.js # checkShardingIndex.
- jstests/core/collection_truncate.js # emptycapped.
- jstests/core/collmod_without_uuid.js # applyOps, SERVER-1439
- jstests/core/compact_keeps_indexes.js # compact.
- jstests/core/currentop.js # uses fsync.
- jstests/core/dbadmin.js # "local" database.
- jstests/core/dbhash.js # dbhash.
- jstests/core/dbhash2.js # dbhash.
- jstests/core/diagdata.js # Command not supported in mongos
Expand Down Expand Up @@ -98,6 +92,7 @@ selector:
- jstests/core/txns/prepare_transaction_fails_on_temp_collections.js

exclude_with_any_tags:
- assumes_standalone_mongod
- assumes_against_mongod_not_mongos
##
# The next tag corresponds to the special error thrown by the set_read_preference_secondary.js
Expand Down
Expand Up @@ -6,10 +6,6 @@ selector:
exclude_files:
# These tests are run in causally_consistent_jscore_txns_passthrough.yml.
- jstests/core/txns/**/*.js
# Cannot specify afterClusterTime and afterOpTime.
- jstests/core/read_after_optime.js
# Not expected to pass with replica-sets.
- jstests/core/opcounters_write_cmd.js
# Has conditional logic for standalone servers and replica sets, but can't distinguish the two
# when connected to mongos.
- jstests/core/write_result.js
Expand All @@ -19,13 +15,11 @@ selector:
- jstests/core/apply_ops*.js # applyOps, SERVER-1439.
- jstests/core/capped_convertToCapped1.js # cloneCollectionAsCapped.
- jstests/core/capped_empty.js # emptycapped.
- jstests/core/capped_update.js # uses godinsert and can't run under replication.
- jstests/core/check_shard_index.js # checkShardingIndex.
- jstests/core/collection_truncate.js # emptycapped.
- jstests/core/collmod_without_uuid.js # applyOps, SERVER-1439
- jstests/core/compact_keeps_indexes.js # compact.
- jstests/core/currentop.js # uses fsync.
- jstests/core/dbadmin.js # "local" database.
- jstests/core/dbhash.js # dbhash.
- jstests/core/dbhash2.js # dbhash.
- jstests/core/diagdata.js # Command not supported in mongos
Expand Down Expand Up @@ -98,6 +92,7 @@ selector:
- jstests/core/txns/prepare_transaction_fails_on_temp_collections.js

exclude_with_any_tags:
- assumes_standalone_mongod
- assumes_against_mongod_not_mongos
##
# The next tag corresponds to the special error thrown by the set_read_preference_secondary.js
Expand Down
Expand Up @@ -16,11 +16,6 @@ selector:
- jstests/core/txns/**/*.js
# Skip any tests that run with auth explicitly.
- jstests/core/*[aA]uth*.js
# Skip any tests that require privileges for non test databases.
# Cannot specify afterClusterTime and afterOpTime.
- jstests/core/read_after_optime.js
# Not expected to pass with replica-sets.
- jstests/core/opcounters_write_cmd.js
# Has conditional logic for standalone servers and replica sets, but can't distinguish the two
# when connected to mongos.
- jstests/core/write_result.js
Expand All @@ -30,13 +25,11 @@ selector:
- jstests/core/apply_ops*.js # applyOps, SERVER-1439.
- jstests/core/capped_convertToCapped1.js # cloneCollectionAsCapped.
- jstests/core/capped_empty.js # emptycapped.
- jstests/core/capped_update.js # uses godinsert and can't run under replication.
- jstests/core/check_shard_index.js # checkShardingIndex.
- jstests/core/collection_truncate.js # emptycapped.
- jstests/core/collmod_without_uuid.js # applyOps, SERVER-1439
- jstests/core/compact_keeps_indexes.js # compact.
- jstests/core/currentop.js # uses fsync.
- jstests/core/dbadmin.js # "local" database.
- jstests/core/dbhash.js # dbhash.
- jstests/core/dbhash2.js # dbhash.
- jstests/core/diagdata.js # Command not supported in mongos
Expand Down Expand Up @@ -130,6 +123,7 @@ selector:

exclude_with_any_tags:
- assumes_against_mongod_not_mongos
- assumes_standalone_mongod
##
# The next tag corresponds to the special error thrown by the set_read_preference_secondary.js
# override when it refuses to replace the readPreference of a particular command. Above each tag
Expand Down
Expand Up @@ -7,16 +7,11 @@ selector:
# Only the first command in a transaction allows readConcern and this suite only tests
# non-transaction snapshot reads.
- jstests/core/txns/**/*.js
# These tests are not expected to pass with replica-sets:
- jstests/core/dbadmin.js
- jstests/core/opcounters_write_cmd.js
- jstests/core/read_after_optime.js
- jstests/core/capped_update.js
# These tests use benchRun(), which isn't configured to use the overridden writeConcern.
- jstests/core/bench_test*.js
- jstests/core/benchrun_pipeline_updates.js # benchRun() used for writes
exclude_with_any_tags:
##
- assumes_standalone_mongod
# The next two tags correspond to the special errors thrown by the
# set_read_and_write_concerns.js override when it refuses to replace the readConcern or
# writeConcern of a particular command. Above each tag are the message(s) that cause the tag to be
Expand Down
9 changes: 3 additions & 6 deletions buildscripts/resmokeconfig/suites/cwrwc_passthrough.yml
Expand Up @@ -7,12 +7,9 @@ test_kind: js_test
selector:
roots:
- jstests/core/**/*.js
exclude_files:
# These tests are not expected to pass with replica-sets:
- jstests/core/dbadmin.js
- jstests/core/opcounters_write_cmd.js
- jstests/core/read_after_optime.js
- jstests/core/capped_update.js

exclude_with_any_tags:
- assumes_standalone_mongod

executor:
archive:
Expand Down
Expand Up @@ -9,15 +9,11 @@ selector:
exclude_files:
# Transactions only a readConcern argument on the first command.
- jstests/core/txns/**/*.js
# These tests are not expected to pass with replica-sets:
- jstests/core/dbadmin.js
- jstests/core/opcounters_write_cmd.js
- jstests/core/read_after_optime.js
- jstests/core/capped_update.js
# These tests use benchRun(), which isn't configured to use the overridden writeConcern.
- jstests/core/bench_test*.js
- jstests/core/benchrun_pipeline_updates.js # benchRun() used for writes
exclude_with_any_tags:
- assumes_standalone_mongod
##
# The next three tags correspond to the special errors thrown by the
# set_read_and_write_concerns.js override when it refuses to replace the readConcern or
Expand Down
Expand Up @@ -9,11 +9,6 @@ selector:
exclude_files:
# Operations within a transaction do not support write concern.
- jstests/core/txns/**/*.js
# These tests are not expected to pass with replica-sets:
- jstests/core/dbadmin.js
- jstests/core/opcounters_write_cmd.js
- jstests/core/read_after_optime.js
- jstests/core/capped_update.js
# The shellkillop.js test spawns a parallel shell without using startParallelShell() and therefore
# doesn't inherit the w="majority" write concern when performing its writes.
- jstests/core/shellkillop.js
Expand All @@ -40,6 +35,7 @@ selector:
# These tests attempt to read from the "system.profile" collection, which may be missing entries
# if a write was performed on the primary of the replica set instead.
- requires_profiling
- assumes_standalone_mongod

executor:
archive:
Expand Down
Expand Up @@ -4,11 +4,6 @@ selector:
roots:
- jstests/core/**/*.js
exclude_files:
# These tests are not expected to pass with replica-sets:
- jstests/core/dbadmin.js
- jstests/core/opcounters_write_cmd.js
- jstests/core/read_after_optime.js
- jstests/core/capped_update.js
# The set_param1.js test attempts to compare the response from running the {getParameter: "*"}
# command multiple times, which may observe the change to the "transactionLifetimeLimitSeconds"
# server parameter.
Expand All @@ -29,6 +24,9 @@ selector:
- jstests/core/find_and_modify_metrics.js
- jstests/core/update_metrics.js

exclude_with_any_tags:
- assumes_standalone_mongod

executor:
archive:
hooks:
Expand Down
Expand Up @@ -4,11 +4,6 @@ selector:
roots:
- jstests/core/**/*.js
exclude_files:
# These tests are not expected to pass with replica-sets:
- jstests/core/dbadmin.js
- jstests/core/opcounters_write_cmd.js
- jstests/core/read_after_optime.js
- jstests/core/capped_update.js
# The set_param1.js test attempts to compare the response from running the {getParameter: "*"}
# command multiple times, which may observe the change to the "transactionLifetimeLimitSeconds"
# server parameter.
Expand All @@ -29,6 +24,9 @@ selector:
- jstests/core/find_and_modify_metrics.js
- jstests/core/update_metrics.js

exclude_with_any_tags:
- assumes_standalone_mongod

executor:
archive:
hooks:
Expand Down
Expand Up @@ -4,11 +4,6 @@ selector:
roots:
- jstests/core/**/*.js
exclude_files:
# These tests are not expected to pass with replica-sets:
- jstests/core/dbadmin.js
- jstests/core/opcounters_write_cmd.js
- jstests/core/read_after_optime.js
- jstests/core/capped_update.js
# The set_param1.js test attempts to compare the response from running the {getParameter: "*"}
# command multiple times, which may observe the change to the "transactionLifetimeLimitSeconds"
# server parameter.
Expand All @@ -29,6 +24,9 @@ selector:
- jstests/core/find_and_modify_metrics.js
- jstests/core/update_metrics.js

exclude_with_any_tags:
- assumes_standalone_mongod

executor:
archive:
hooks:
Expand Down
Expand Up @@ -4,11 +4,6 @@ selector:
roots:
- jstests/core/**/*.js
exclude_files:
# These tests are not expected to pass with replica-sets:
- jstests/core/dbadmin.js
- jstests/core/opcounters_write_cmd.js
- jstests/core/read_after_optime.js
- jstests/core/capped_update.js
# The set_param1.js test attempts to compare the response from running the {getParameter: "*"}
# command multiple times, which may observe the change to the "transactionLifetimeLimitSeconds"
# server parameter.
Expand All @@ -29,6 +24,9 @@ selector:
- jstests/core/find_and_modify_metrics.js
- jstests/core/update_metrics.js

exclude_with_any_tags:
- assumes_standalone_mongod

executor:
archive:
hooks:
Expand Down
Expand Up @@ -18,7 +18,6 @@ selector:
- jstests/core/collmod_without_uuid.js # applyOps, SERVER-1439
- jstests/core/compact_keeps_indexes.js # compact.
- jstests/core/currentop.js # uses fsync.
- jstests/core/dbadmin.js # "local" database.
- jstests/core/dbhash.js # dbhash.
- jstests/core/dbhash2.js # dbhash.
- jstests/core/diagdata.js # Command not supported in mongos
Expand All @@ -44,8 +43,6 @@ selector:
- jstests/core/geo_s2explain.js # inputStage in different spot in explain().
- jstests/core/geo_s2sparse.js # keysPerIndex in different spot in validate().
- jstests/core/operation_latency_histogram.js # Stats are counted differently on mongos, SERVER-24880.
# Test expects to run against a standalone, but shards in this passthrough are repl sets.
- jstests/core/read_after_optime.js
# The following tests fail because they count indexes. These counts do not take into account the
# additional hashed shard key indexes that are automatically added by this passthrough.
- jstests/core/apitest_dbcollection.js
Expand Down Expand Up @@ -92,6 +89,7 @@ selector:
- jstests/core/txns/prepare_transaction_fails_on_temp_collections.js

exclude_with_any_tags:
- assumes_standalone_mongod
- assumes_against_mongod_not_mongos
# Tests tagged with the following will fail because they assume collections are not sharded.
- assumes_no_implicit_collection_creation_after_drop
Expand Down
Expand Up @@ -18,7 +18,6 @@ selector:
- jstests/core/collmod_without_uuid.js # applyOps, SERVER-1439
- jstests/core/compact_keeps_indexes.js # compact.
- jstests/core/currentop.js # uses fsync.
- jstests/core/dbadmin.js # "local" database.
- jstests/core/dbhash.js # dbhash.
- jstests/core/dbhash2.js # dbhash.
- jstests/core/diagdata.js # Command not supported in mongos
Expand All @@ -44,8 +43,6 @@ selector:
- jstests/core/geo_s2explain.js # inputStage in different spot in explain().
- jstests/core/geo_s2sparse.js # keysPerIndex in different spot in validate().
- jstests/core/operation_latency_histogram.js # Stats are counted differently on mongos, SERVER-24880.
# Test expects to run against a standalone, but shards in this passthrough are repl sets.
- jstests/core/read_after_optime.js
# The following tests fail because they count indexes. These counts do not take into account the
# additional hashed shard key indexes that are automatically added by this passthrough.
- jstests/core/apitest_dbcollection.js
Expand Down Expand Up @@ -92,6 +89,7 @@ selector:
- jstests/core/txns/prepare_transaction_fails_on_temp_collections.js

exclude_with_any_tags:
- assumes_standalone_mongod
- assumes_against_mongod_not_mongos
# Tests tagged with the following will fail because they assume collections are not sharded.
- assumes_no_implicit_collection_creation_after_drop
Expand Down
Expand Up @@ -18,7 +18,6 @@ selector:
- jstests/core/collmod_without_uuid.js # applyOps, SERVER-1439
- jstests/core/compact_keeps_indexes.js # compact.
- jstests/core/currentop.js # uses fsync.
- jstests/core/dbadmin.js # "local" database.
- jstests/core/dbhash.js # dbhash.
- jstests/core/dbhash2.js # dbhash.
- jstests/core/diagdata.js # Command not supported in mongos
Expand All @@ -44,8 +43,6 @@ selector:
- jstests/core/geo_s2explain.js # inputStage in different spot in explain().
- jstests/core/geo_s2sparse.js # keysPerIndex in different spot in validate().
- jstests/core/operation_latency_histogram.js # Stats are counted differently on mongos, SERVER-24880.
# Test expects to run against a standalone, but shards in this passthrough are repl sets.
- jstests/core/read_after_optime.js
# The following tests fail because they count indexes. These counts do not take into account the
# additional hashed shard key indexes that are automatically added by this passthrough.
- jstests/core/apitest_dbcollection.js
Expand Down Expand Up @@ -92,6 +89,7 @@ selector:
- jstests/core/txns/prepare_transaction_fails_on_temp_collections.js

exclude_with_any_tags:
- assumes_standalone_mongod
- assumes_against_mongod_not_mongos
# Tests tagged with the following will fail because they assume collections are not sharded.
- assumes_no_implicit_collection_creation_after_drop
Expand Down
Expand Up @@ -18,7 +18,6 @@ selector:
- jstests/core/collmod_without_uuid.js # applyOps, SERVER-1439
- jstests/core/compact_keeps_indexes.js # compact.
- jstests/core/currentop.js # uses fsync.
- jstests/core/dbadmin.js # "local" database.
- jstests/core/dbhash.js # dbhash.
- jstests/core/dbhash2.js # dbhash.
- jstests/core/diagdata.js # Command not supported in mongos
Expand All @@ -44,8 +43,6 @@ selector:
- jstests/core/geo_s2explain.js # inputStage in different spot in explain().
- jstests/core/geo_s2sparse.js # keysPerIndex in different spot in validate().
- jstests/core/operation_latency_histogram.js # Stats are counted differently on mongos, SERVER-24880.
# Test expects to run against a standalone, but shards in this passthrough are repl sets.
- jstests/core/read_after_optime.js
# The following tests fail because they count indexes. These counts do not take into account the
# additional hashed shard key indexes that are automatically added by this passthrough.
- jstests/core/apitest_dbcollection.js
Expand Down Expand Up @@ -92,6 +89,7 @@ selector:
- jstests/core/txns/prepare_transaction_fails_on_temp_collections.js

exclude_with_any_tags:
- assumes_standalone_mongod
- assumes_against_mongod_not_mongos
# Tests tagged with the following will fail because they assume collections are not sharded.
- assumes_no_implicit_collection_creation_after_drop
Expand Down
Expand Up @@ -19,7 +19,6 @@ selector:
- jstests/core/collmod_without_uuid.js # applyOps, SERVER-1439
- jstests/core/compact_keeps_indexes.js # compact.
- jstests/core/currentop.js # uses fsync.
- jstests/core/dbadmin.js # "local" database.
- jstests/core/dbhash.js # dbhash.
- jstests/core/dbhash2.js # dbhash.
- jstests/core/diagdata.js # Command not supported in mongos
Expand All @@ -44,8 +43,6 @@ selector:
- jstests/core/geo_s2explain.js # inputStage in different spot in explain().
- jstests/core/geo_s2sparse.js # keysPerIndex in different spot in validate().
- jstests/core/operation_latency_histogram.js # Stats are counted differently on mongos, SERVER-24880.
# Test expects to run against a standalone, but shards in this passthrough are repl sets.
- jstests/core/read_after_optime.js
# The following tests fail because they count indexes. These counts do not take into account the
# additional hashed shard key indexes that are automatically added by this passthrough.
- jstests/core/apitest_dbcollection.js
Expand Down Expand Up @@ -139,9 +136,6 @@ selector:
- jstests/core/updateh.js
- jstests/core/updatej.js

# SERVER-38096 Mongos opCounter doesn't increase when last op causes the transaction to implicitly abort
- jstests/core/opcounters_write_cmd.js

# TODO: SERVER-38207 Cannot insert document with MaxKey shard key.
- jstests/core/type8.js

Expand Down Expand Up @@ -289,6 +283,7 @@ selector:
# "writeConcern is not allowed within a multi-statement transaction"
- assumes_write_concern_unchanged
- assumes_against_mongod_not_mongos
- assumes_standalone_mongod
# Tests tagged with the following will fail because they assume collections are not sharded.
- assumes_no_implicit_collection_creation_after_drop
- assumes_no_implicit_index_creation
Expand Down

0 comments on commit cc4854a

Please sign in to comment.