Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVER-15793 Pass the old record to the storage engine's updateRecord function. #837

Closed
wants to merge 3 commits into from

Conversation

@esmet
Copy link
Contributor

esmet commented Oct 24, 2014

Now, any updateRecord implementation that needs the old record
no longer needs to do a read-before-write. One possible implementation is
a RecordStore that maintains the data size of all records and needs to
know the size delta of every update.

The upstream rocks engine will immediately benefit from this. I have not included any changes to rocks, however, as that is outside of my realm.

https://jira.mongodb.org/browse/SERVER-15793

All unit tests pass and so do the core js tests that start with 'update' (ie: jstests/core/update*'

esmet added 2 commits Oct 24, 2014
function. Now, any updateRecord implementation that needs the old record
no longer needs to do a read-before-write. One possible implementation is
a RecordStore that maintains the data size of all records and needs to
know the size delta of every update.
@esmet esmet closed this Oct 24, 2014
@esmet

This comment has been minimized.

Copy link
Contributor Author

esmet commented Oct 24, 2014

Something is off with the above commit - keeping closed until I can verify if it's a code problem or an environment problem.

@esmet

This comment has been minimized.

Copy link
Contributor Author

esmet commented Oct 24, 2014

Okay, tests run fine, must have been a ghost in my build system.

@esmet esmet reopened this Oct 24, 2014
@esmet

This comment has been minimized.

Copy link
Contributor Author

esmet commented Oct 29, 2014

Any thoughts on this?

@esmet esmet changed the title Pass the old record to the storage engine's updateRecord function. SERVER-15793 Pass the old record to the storage engine's updateRecord function. Oct 29, 2014
…_record_oldrec

Conflicts:
	src/mongo/db/storage/heap1/record_store_heap.cpp
@benety

This comment has been minimized.

Copy link
Contributor

benety commented Jan 17, 2015

@esmet,

Sorry for taking this long to get back to you. I am having some trouble rebasing this patch on current master (c3da2fc) - there's been quite a few changes to the interface (for example renaming DiskLoc to RecordId). I would like to close this pull request at this time - if you have a patch against a more recent version of the source tree, please feel free to open a new pull request.

Ben

@gevorgvoskanyan

This comment has been minimized.

Copy link

gevorgvoskanyan commented Jan 18, 2015

@esmet, @benety,

I have proposed a new PR based on this: #912
Please let me know if that one is OK to merge.

Thanks,
Gevorg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.