CLOUDP-66895: Move snyk scanner to evergreen #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaiBojin
approved these changes
Jul 29, 2020
| params: | ||
| working_dir: src/github.com/mongodb/mongocli | ||
| script: | | ||
| export SNYK_TOKEN=${snyk_token} |
Contributor
There was a problem hiding this comment.
nit: export before set and also more exports below
Contributor
Author
There was a problem hiding this comment.
before because it's a secret, it's an evergreen thing do move these kind of expansions before the sets also for expansions we usually don't use quotes("") but I can try it
| set -Eeou pipefail | ||
| export GOROOT="${go_root}" | ||
| export PATH="./bin:$GOROOT/bin:$PATH" |
Contributor
Author
There was a problem hiding this comment.
I left them because I'm not sure if snyk needs a working go env to run, if there's no GOROOT set go complains a lot, it has a default usually but that's not set on evergreen
Contributor
Author
There was a problem hiding this comment.
Yes, goroot is needed, test here without it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-66895
Checklist
make fmtand formatted my codeFurther comments