diff --git a/internal/translayer/auditing/auditing.go b/internal/translayer/auditing/auditing.go index a944384365..fc8a1ab0ff 100644 --- a/internal/translayer/auditing/auditing.go +++ b/internal/translayer/auditing/auditing.go @@ -12,36 +12,36 @@ import ( "github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/controller/atlas" ) -type Service interface { +type AtlasAuditService interface { Get(ctx context.Context, projectID string) (*Auditing, error) Set(ctx context.Context, projectID string, auditing *Auditing) error } -type service struct { - admin.AuditingApi +type ProductionAtlasAudit struct { + auditAPI admin.AuditingApi } -func NewService(ctx context.Context, provider atlas.Provider, secretRef *types.NamespacedName, log *zap.SugaredLogger) (Service, error) { +func NewService(ctx context.Context, provider atlas.Provider, secretRef *types.NamespacedName, log *zap.SugaredLogger) (*ProductionAtlasAudit, error) { client, err := translayer.NewVersionedClient(ctx, provider, secretRef, log) if err != nil { return nil, err } - return NewFromAuditingAPI(client.AuditingApi), nil + return NewProductionAtlasAudit(client.AuditingApi), nil } -func NewFromAuditingAPI(api admin.AuditingApi) *service { - return &service{AuditingApi: api} +func NewProductionAtlasAudit(api admin.AuditingApi) *ProductionAtlasAudit { + return &ProductionAtlasAudit{auditAPI: api} } -func (s *service) Get(ctx context.Context, projectID string) (*Auditing, error) { - auditLog, _, err := s.AuditingApi.GetAuditingConfiguration(ctx, projectID).Execute() +func (s *ProductionAtlasAudit) Get(ctx context.Context, projectID string) (*Auditing, error) { + auditLog, _, err := s.auditAPI.GetAuditingConfiguration(ctx, projectID).Execute() if err != nil { return nil, fmt.Errorf("failed to get audit log from Atlas: %w", err) } return fromAtlas(auditLog) } -func (s *service) Set(ctx context.Context, projectID string, auditing *Auditing) error { - _, _, err := s.AuditingApi.UpdateAuditingConfiguration(ctx, projectID, toAtlas(auditing)).Execute() +func (s *ProductionAtlasAudit) Set(ctx context.Context, projectID string, auditing *Auditing) error { + _, _, err := s.auditAPI.UpdateAuditingConfiguration(ctx, projectID, toAtlas(auditing)).Execute() return err } diff --git a/test/contract/auditing/auditing_test.go b/test/contract/auditing/auditing_test.go index da7b6535ce..29b2c96d0a 100644 --- a/test/contract/auditing/auditing_test.go +++ b/test/contract/auditing/auditing_test.go @@ -42,7 +42,7 @@ func TestMain(m *testing.M) { func TestDefaultAuditingGet(t *testing.T) { testProjectID := mustReadProjectID() ctx := context.Background() - as := auditing.NewFromAuditingAPI(contract.MustVersionedClient(t, ctx).AuditingApi) + as := auditing.NewProductionAtlasAudit(contract.MustVersionedClient(t, ctx).AuditingApi) result, err := as.Get(ctx, testProjectID) @@ -119,7 +119,7 @@ func TestSyncs(t *testing.T) { } testProjectID := mustReadProjectID() ctx := context.Background() - as := auditing.NewFromAuditingAPI(contract.MustVersionedClient(t, ctx).AuditingApi) + as := auditing.NewProductionAtlasAudit(contract.MustVersionedClient(t, ctx).AuditingApi) for _, tc := range testCases { t.Run(tc.title, func(t *testing.T) {