Skip to content

Conversation

@josvazg
Copy link
Collaborator

@josvazg josvazg commented Jun 22, 2023

May allow us to close PR #1000

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

dependabot bot and others added 2 commits June 22, 2023 06:34
Bumps [go.mongodb.org/atlas](https://github.com/mongodb/go-client-mongodb-atlas) from 0.28.0 to 0.29.0.
- [Release notes](https://github.com/mongodb/go-client-mongodb-atlas/releases)
- [Changelog](https://github.com/mongodb/go-client-mongodb-atlas/blob/master/CHANGELOG.md)
- [Commits](mongodb/go-client-mongodb-atlas@v0.28.0...v0.29.0)

---
updated-dependencies:
- dependency-name: go.mongodb.org/atlas
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
@github-actions
Copy link
Contributor

@helderjs
Copy link
Collaborator

@josvazg I just noticed that I have this already in this PR https://github.com/mongodb/mongodb-atlas-kubernetes/pull/986/files#diff-497a20a60e82f346266418177e3377d67507c3ad4c91bd623ace10f413a05b6eR447
I just need to update/rebase it and put it back to review

Also, tomorrow we can quickly talk about some constraints we need to have in mind for PRs, you have committed files that are not supposed to be on features PRs

@josvazg
Copy link
Collaborator Author

josvazg commented Jun 22, 2023

@josvazg I just noticed that I have this already in this PR https://github.com/mongodb/mongodb-atlas-kubernetes/pull/986/files#diff-497a20a60e82f346266418177e3377d67507c3ad4c91bd623ace10f413a05b6eR447 I just need to update/rebase it and put it back to review

Also, tomorrow we can quickly talk about some constraints we need to have in mind for PRs, you have committed files that are not supposed to be on features PRs

Right!

I think I also made a mistake and this PR has changes about things I was testing yesterday. That was unintended.

Will just close it now.

@josvazg josvazg closed this Jun 22, 2023
@roothorp roothorp deleted the upgrade/atlas-0.29.0 branch September 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants